* [PATCH] scsi: Clean up errors in sni_53c710.c
@ 2023-09-27 8:37 chenguohua
2023-09-28 13:24 ` James Bottomley
0 siblings, 1 reply; 2+ messages in thread
From: chenguohua @ 2023-09-27 8:37 UTC (permalink / raw)
To: jejb, martin.petersen; +Cc: linux-scsi, linux-kernel
Fix the following errors reported by checkpatch:
ERROR: space required before the open parenthesis '('
Signed-off-by: GuoHua Cheng <chenguohua@jari.cn>
---
drivers/scsi/sni_53c710.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/scsi/sni_53c710.c b/drivers/scsi/sni_53c710.c
index 678651b9b4dd..e226225d1237 100644
--- a/drivers/scsi/sni_53c710.c
+++ b/drivers/scsi/sni_53c710.c
@@ -86,7 +86,7 @@ static int snirm710_probe(struct platform_device *dev)
host->irq = rc = platform_get_irq(dev, 0);
if (rc < 0)
goto out_put_host;
- if(request_irq(host->irq, NCR_700_intr, IRQF_SHARED, "snirm710", host)) {
+ if (request_irq(host->irq, NCR_700_intr, IRQF_SHARED, "snirm710", host)) {
printk(KERN_ERR "snirm710: request_irq failed!\n");
goto out_put_host;
}
--
2.17.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] scsi: Clean up errors in sni_53c710.c
2023-09-27 8:37 [PATCH] scsi: Clean up errors in sni_53c710.c chenguohua
@ 2023-09-28 13:24 ` James Bottomley
0 siblings, 0 replies; 2+ messages in thread
From: James Bottomley @ 2023-09-28 13:24 UTC (permalink / raw)
To: chenguohua, martin.petersen; +Cc: linux-scsi, linux-kernel
On Wed, 2023-09-27 at 16:37 +0800, chenguohua@jari.cn wrote:
> Fix the following errors reported by checkpatch:
>
> ERROR: space required before the open parenthesis '('
checkpatch is advisory, not mandatory.
While we usually fix its errors and warnings on current patches,
checkpatch changes over time and code it once accepted sometimes no
longer passes. For that reason we don't accept patches to in-tree
files which now fail checkpatch because there are a huge number of them
and it generates an awful lot of churn which ends up either causing
bugs or interfering with current development.
Regards,
James
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-09-28 13:26 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-09-27 8:37 [PATCH] scsi: Clean up errors in sni_53c710.c chenguohua
2023-09-28 13:24 ` James Bottomley
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).