Re: [PATCH v2 10/13] ata: libata: Assign print_id at port allocation time

Hannes Reinecke
2024-06-27T06:38:33Z

On 6/26/24 20:00, Niklas Cassel wrote:
> While the assignment of ap->print_id could have been moved to
> ata_host_alloc(), let's simply move it to ata_port_alloc().
>
> If you allocate a port, you want to give it a unique name that can be used
> for printing.
>
> By moving the ap->print_id assignment to ata_port_alloc(), means that we
> can also remove the ap->print_id assignment from ata_sas_port_alloc().
>
> This will allow a LLD to use the ata_port_*() print functions before
> ata_host_register() has been called.
>
> Reviewed-by: Damien Le Moal <dlemoal@kernel.org>
> Signed-off-by: Niklas Cassel <cassel@kernel.org>
> ---
> drivers/ata/libata-core.c | 6 +-----
> drivers/ata/libata-sata.c | 1 -
> 2 files changed, 1 insertion(+), 6 deletions(-)
>
Reviewed-by: Hannes Reinecke <hare@suse.de>

Cheers,

Hannes
--
Dr. Hannes Reinecke Kernel Storage Architect
hare@suse.de +49 911 74053 688
SUSE Software Solutions GmbH, Frankenstr. 146, 90461 Nürnberg
HRB 36809 (AG Nürnberg), GF: I. Totev, A. McDonald, W. Knoblich