Re: [PATCH v2 00/13] ata,libsas: Assign the unique id used for printing earlier

John Garry
2024-06-27T12:26:47Z

On 26/06/2024 19:00, Niklas Cassel wrote:
> Hello all,
>
> This patch series was orginally meant to simply assign a unique id used
> for printing earlier (ap->print_id), but has since grown to also include
> cleanups related to ata_port_alloc() (since ap->print_id is now assigned
> in ata_port_alloc()).
>

There's no real problem statement wrt print_id, telling how and why
things are like they are, how it is a problem, and how it is improved in
this series.

> Patch 1-3 fixes incorrect cleanups in the error paths.
> Patch 4,12 removes a useless libata wrappers only used for libsas.
> Patch 5 introduces a ata_port_free(), in order to avoid duplicated code.
> Patch 6 removes a unused function declaration in include/linux/libata.h.
> Patch 7 remove support for decreasing the number of ports, as it is never
> used by any libata driver (including libsas and ipr).
> Patch 8 removes a superfluous assignment in ata_sas_port_alloc().
> Patch 9 removes the unnecessary local_port_no struct member in ata_port.
> Patch 10 performs the ata_port print_id assignment earlier, so that the
> ata_port_* print functions can be used even before the ata_host
> has been registered.
> Patch 11 changes the print_id assignment to use an ida_alloc(), such that
> we will reuse IDs that are no longer in use, rather than keep
> increasing the print_id forever.
> Patch 13 adds a debug print in case the port is marked as external, this
> code runs before the ata_host has been registered, so it depends
> on patch 10.