Re: [PATCH v2 13/13] ata: ahci: Add debug print for external port

Hannes Reinecke
2024-06-27T06:40:42Z

On 6/26/24 20:00, Niklas Cassel wrote:
> Add a debug print that tells us if LPM is not getting enabled because the
> port is external.
>
> Reviewed-by: Damien Le Moal <dlemoal@kernel.org>
> Signed-off-by: Niklas Cassel <cassel@kernel.org>
> ---
> drivers/ata/ahci.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/ata/ahci.c b/drivers/ata/ahci.c
> index fc6fd583faf8..a05c17249448 100644
> --- a/drivers/ata/ahci.c
> +++ b/drivers/ata/ahci.c
> @@ -1732,8 +1732,10 @@ static void ahci_update_initial_lpm_policy(struct ata_port *ap)
> * Management Interaction in AHCI 1.3.1. Therefore, do not enable
> * LPM if the port advertises itself as an external port.
> */
> - if (ap->pflags & ATA_PFLAG_EXTERNAL)
> + if (ap->pflags & ATA_PFLAG_EXTERNAL) {
> + ata_port_dbg(ap, "external port, not enabling LPM\n");
> return;
> + }
>
> /* If no LPM states are supported by the HBA, do not bother with LPM */
> if ((ap->host->flags & ATA_HOST_NO_PART) &&

Reviewed-by: Hannes Reinecke <hare@suse.de>

Cheers,

Hannes
--
Dr. Hannes Reinecke Kernel Storage Architect
hare@suse.de +49 911 74053 688
SUSE Software Solutions GmbH, Frankenstr. 146, 90461 Nürnberg
HRB 36809 (AG Nürnberg), GF: I. Totev, A. McDonald, W. Knoblich