* [PATCH] scsi: ufs-qcom: Fix module autoload
@ 2017-01-02 14:04 Javier Martinez Canillas
2017-01-04 1:06 ` Subhash Jadavani
2017-01-05 23:21 ` Martin K. Petersen
0 siblings, 2 replies; 3+ messages in thread
From: Javier Martinez Canillas @ 2017-01-02 14:04 UTC (permalink / raw)
To: linux-kernel
Cc: Javier Martinez Canillas, Martin K. Petersen, Vinayak Holikatti,
linux-scsi, James E.J. Bottomley
If the driver is built as a module, autoload won't work because the module
alias information is not filled. So user-space can't match the registered
device with the corresponding module.
Export the module alias information using the MODULE_DEVICE_TABLE() macro.
Before this patch:
$ modinfo drivers/scsi/ufs/ufs-qcom.ko | grep alias
$
After this patch:
$ modinfo drivers/scsi/ufs/ufs-qcom.ko | grep alias
alias: of:N*T*Cqcom,ufshcC*
alias: of:N*T*Cqcom,ufshc
Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
---
drivers/scsi/ufs/ufs-qcom.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/scsi/ufs/ufs-qcom.c b/drivers/scsi/ufs/ufs-qcom.c
index abe617372661..5ff8a6bf6fd3 100644
--- a/drivers/scsi/ufs/ufs-qcom.c
+++ b/drivers/scsi/ufs/ufs-qcom.c
@@ -1692,6 +1692,7 @@ static const struct of_device_id ufs_qcom_of_match[] = {
{ .compatible = "qcom,ufshc"},
{},
};
+MODULE_DEVICE_TABLE(of, ufs_qcom_of_match);
static const struct dev_pm_ops ufs_qcom_pm_ops = {
.suspend = ufshcd_pltfrm_suspend,
--
2.7.4
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] scsi: ufs-qcom: Fix module autoload
2017-01-02 14:04 [PATCH] scsi: ufs-qcom: Fix module autoload Javier Martinez Canillas
@ 2017-01-04 1:06 ` Subhash Jadavani
2017-01-05 23:21 ` Martin K. Petersen
1 sibling, 0 replies; 3+ messages in thread
From: Subhash Jadavani @ 2017-01-04 1:06 UTC (permalink / raw)
To: Javier Martinez Canillas
Cc: linux-kernel, Martin K. Petersen, Vinayak Holikatti, linux-scsi,
James E.J. Bottomley, linux-scsi-owner
On 2017-01-02 06:04, Javier Martinez Canillas wrote:
> If the driver is built as a module, autoload won't work because the
> module
> alias information is not filled. So user-space can't match the
> registered
> device with the corresponding module.
>
> Export the module alias information using the MODULE_DEVICE_TABLE()
> macro.
>
> Before this patch:
>
> $ modinfo drivers/scsi/ufs/ufs-qcom.ko | grep alias
> $
>
> After this patch:
>
> $ modinfo drivers/scsi/ufs/ufs-qcom.ko | grep alias
> alias: of:N*T*Cqcom,ufshcC*
> alias: of:N*T*Cqcom,ufshc
>
> Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
> ---
>
> drivers/scsi/ufs/ufs-qcom.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/scsi/ufs/ufs-qcom.c b/drivers/scsi/ufs/ufs-qcom.c
> index abe617372661..5ff8a6bf6fd3 100644
> --- a/drivers/scsi/ufs/ufs-qcom.c
> +++ b/drivers/scsi/ufs/ufs-qcom.c
> @@ -1692,6 +1692,7 @@ static const struct of_device_id
> ufs_qcom_of_match[] = {
> { .compatible = "qcom,ufshc"},
> {},
> };
> +MODULE_DEVICE_TABLE(of, ufs_qcom_of_match);
>
> static const struct dev_pm_ops ufs_qcom_pm_ops = {
> .suspend = ufshcd_pltfrm_suspend,
Looks good to me.
Reviewed-by: Subhash Jadavani <subhashj@codeaurora.org>
--
The Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] scsi: ufs-qcom: Fix module autoload
2017-01-02 14:04 [PATCH] scsi: ufs-qcom: Fix module autoload Javier Martinez Canillas
2017-01-04 1:06 ` Subhash Jadavani
@ 2017-01-05 23:21 ` Martin K. Petersen
1 sibling, 0 replies; 3+ messages in thread
From: Martin K. Petersen @ 2017-01-05 23:21 UTC (permalink / raw)
To: Javier Martinez Canillas
Cc: linux-kernel, Martin K. Petersen, Vinayak Holikatti, linux-scsi,
James E.J. Bottomley
>>>>> "Javier" == Javier Martinez Canillas <javier@osg.samsung.com> writes:
Javier> If the driver is built as a module, autoload won't work because
Javier> the module alias information is not filled. So user-space can't
Javier> match the registered device with the corresponding module.
Javier> Export the module alias information using the
Javier> MODULE_DEVICE_TABLE() macro.
Applied to 4.11/scsi-queue.
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-01-05 23:21 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-01-02 14:04 [PATCH] scsi: ufs-qcom: Fix module autoload Javier Martinez Canillas
2017-01-04 1:06 ` Subhash Jadavani
2017-01-05 23:21 ` Martin K. Petersen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).