From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 11F5EC4332F for ; Thu, 2 Nov 2023 07:59:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234386AbjKBH7Y (ORCPT ); Thu, 2 Nov 2023 03:59:24 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42188 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229481AbjKBH7W (ORCPT ); Thu, 2 Nov 2023 03:59:22 -0400 Received: from smtp-out2.suse.de (smtp-out2.suse.de [IPv6:2001:67c:2178:6::1d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 066B5E7; Thu, 2 Nov 2023 00:59:17 -0700 (PDT) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id AC9E71F853; Thu, 2 Nov 2023 07:59:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1698911955; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ybwwKa/cgRGGfYQ6tN6QVFtmPhHlMVKZso5z0IiB8j8=; b=IsWsPOBANibPS82/8K46HjZWKfdFG7xw1YKrc+2zJWscCaHfZyPv9v0cU5SahaMOvaXgW0 kUPa6MXDhLbiqkOEmiv5JQsyC3H7fWb0nKaQOrbeDQnsEGWqQLVUID0NDa1+kkYeNXVH/t fHGA6Y5VdLUpbDCenzFUi1UdBoBb7Hs= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1698911955; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ybwwKa/cgRGGfYQ6tN6QVFtmPhHlMVKZso5z0IiB8j8=; b=ZIcHeyL0u7tHWUxOfnr6exfRhCTAJQ9HDpdwnU6zx2IQ+da0XXHyKUw0Op3bPbzJdKB0wH nfSfO57XHtkPMKDQ== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id B65D613584; Thu, 2 Nov 2023 07:59:14 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id gFhNKtJWQ2W1PQAAMHmgww (envelope-from ); Thu, 02 Nov 2023 07:59:14 +0000 Message-ID: <2e7c1749-428b-4c88-8e0e-df6ed4d8def5@suse.de> Date: Thu, 2 Nov 2023 08:59:14 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 13/13] scsi: fnic: Improve logs and add support for multiqueue (MQ) Content-Language: en-US To: Karan Tilak Kumar , sebaddel@cisco.com Cc: arulponn@cisco.com, djhawar@cisco.com, gcboffa@cisco.com, mkai2@cisco.com, satishkh@cisco.com, jejb@linux.ibm.com, martin.petersen@oracle.com, linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org References: <20231027180302.418676-1-kartilak@cisco.com> <20231027180302.418676-14-kartilak@cisco.com> From: Hannes Reinecke In-Reply-To: <20231027180302.418676-14-kartilak@cisco.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org On 10/27/23 20:03, Karan Tilak Kumar wrote: > Improve existing logs by adding fnic number, hardware queue, > tag, and mqtag in the prints. > Add logs with the above elements for effective debugging. > > Reviewed-by: Sesidhar Baddela > Reviewed-by: Arulprabhu Ponnusamy > Tested-by: Karan Tilak Kumar > Signed-off-by: Karan Tilak Kumar > --- > drivers/scsi/fnic/fnic.h | 2 +- > drivers/scsi/fnic/fnic_scsi.c | 127 ++++++++++++++++++++-------------- > 2 files changed, 77 insertions(+), 52 deletions(-) > > diff --git a/drivers/scsi/fnic/fnic.h b/drivers/scsi/fnic/fnic.h > index 87dab09a426d..0f1581c1fb4a 100644 > --- a/drivers/scsi/fnic/fnic.h > +++ b/drivers/scsi/fnic/fnic.h > @@ -27,7 +27,7 @@ > > #define DRV_NAME "fnic" > #define DRV_DESCRIPTION "Cisco FCoE HBA Driver" > -#define DRV_VERSION "1.6.0.56" > +#define DRV_VERSION "1.6.0.58" > #define PFX DRV_NAME ": " > #define DFX DRV_NAME "%d: " > Please move this change to the last patch. And I would wager that this change is more intrusive than a simple patch, so an update to 1.7 or even 2.0 is warranted. Otherwise: Reviewed-by: Hannes Reinecke -- Dr. Hannes Reinecke Kernel Storage Architect hare@suse.de +49 911 74053 688 SUSE Software Solutions GmbH, Maxfeldstr. 5, 90409 Nürnberg HRB 36809 (AG Nürnberg), Geschäftsführer: Ivo Totev, Andrew Myers, Andrew McDonald, Martje Boudien Moerman