From: Paolo Bonzini <pbonzini@redhat.com>
To: John Snow <jsnow@redhat.com>, Hannes Reinecke <hare@suse.de>,
emilne@redhat.com
Cc: linux-scsi@vger.kernel.org
Subject: Re: [PATCH] scsi: Add QEMU CD-ROM to VPD Inquiry Blacklist
Date: Mon, 6 Jun 2016 18:03:46 +0200 [thread overview]
Message-ID: <2e9d3296-3da3-aef0-521c-d096daa37c21@redhat.com> (raw)
In-Reply-To: <d84ec540-bfcb-8ce3-8615-bcfeb0271270@redhat.com>
On 06/06/2016 17:47, John Snow wrote:
> > > Various downstreams may have backported the VPD fix to older versions,
> > > we need to be careful not to block those, too ... so targeting the core
> > > behavior seems like the more strictly correct, easily maintainable solution.
> >
> > I think this is not practical. I'm okay with the big hammer if an
> > algorithmic fix is not feasible; but otherwise it does seem a better
> > idea than blacklisting based on inquiry data...
>
> You think the more practical solution is a SCSI driver that can hang
> because of an incorrect/missing response and to maintain a carefully
> curated blacklist to work around this behavior?
The best solution would be an algorithmic fix, perhaps predicated by
some kind of quirk bit.
A carefully curated blacklist is impossible because you cannot account
for a zillion downstreams, most of which probably don't change the
inquire vendor/product data; version numbers are awful.
Paolo
prev parent reply other threads:[~2016-06-06 16:03 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-31 13:42 [PATCH] scsi: Add QEMU CD-ROM to VPD Inquiry Blacklist Ewan D. Milne
2016-05-31 13:43 ` Johannes Thumshirn
2016-06-03 3:19 ` Tom Yan
[not found] ` <CAGnHSEmS7NzEFK7uD357r6Y=xU5o1O0i+AU5qhmqcqjmp_K0Lw@mail.gmail.com>
2016-06-03 14:36 ` Ewan D. Milne
2016-06-03 19:14 ` Tom Yan
2016-06-03 19:19 ` Ewan D. Milne
2016-06-03 21:14 ` Bart Van Assche
2016-06-06 7:34 ` Hannes Reinecke
2016-06-06 14:11 ` Ewan D. Milne
2016-06-06 14:22 ` Hannes Reinecke
2016-06-06 15:05 ` Paolo Bonzini
2016-06-06 15:41 ` John Snow
2016-06-06 15:43 ` Paolo Bonzini
2016-06-06 15:47 ` John Snow
2016-06-06 16:03 ` Paolo Bonzini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2e9d3296-3da3-aef0-521c-d096daa37c21@redhat.com \
--to=pbonzini@redhat.com \
--cc=emilne@redhat.com \
--cc=hare@suse.de \
--cc=jsnow@redhat.com \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).