From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id ED4C3C433F5 for ; Thu, 17 Feb 2022 03:08:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232373AbiBQDIN (ORCPT ); Wed, 16 Feb 2022 22:08:13 -0500 Received: from mxb-00190b01.gslb.pphosted.com ([23.128.96.19]:60248 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232133AbiBQDIN (ORCPT ); Wed, 16 Feb 2022 22:08:13 -0500 Received: from mail-pj1-x102a.google.com (mail-pj1-x102a.google.com [IPv6:2607:f8b0:4864:20::102a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 409F61738CE for ; Wed, 16 Feb 2022 19:08:00 -0800 (PST) Received: by mail-pj1-x102a.google.com with SMTP id v13-20020a17090ac90d00b001b87bc106bdso8183895pjt.4 for ; Wed, 16 Feb 2022 19:08:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20210112.gappssmtp.com; s=20210112; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=m0P9N0WVb6AAY2j7DvviRpPpziBTQrcj2AKsHwgmWuw=; b=MXrMezWjXbcndPIug7qJGx/KHFAQ7CSHaswSmR9MRANlQU9yJCNBptTPJazM8l/YCk mqAxPoN1u3ukSKF6AZDJQUqb/ILcTsmm6odOPcNe+AecyCA6qkVUDjo2VMVuqzKHNs4v 1BvU4cBk2ewB20ZLqR9BXLWfclLCTn/j5n+vya9PD7VgV4uAfHaosnxKv5YylxkqkbJP Ho8xLE0N7fAh/qK0Kkmy6ySJtwCLcyM2EmOOvxYa1X5/mFmuwFYaNotlT5W4Kk0zq2oM OBsmIxWQbbP+Fxvvwx8eeEcAZMg3ZwmKFevlXqa6T5omJ5uYlILM7KsI3b8t7lDKfRU0 xGGQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=m0P9N0WVb6AAY2j7DvviRpPpziBTQrcj2AKsHwgmWuw=; b=TaLDG4wRyGsVVnTAgEBkkKg26gQYzVJbRxHxdpUmFpk0HWuF0pGzug1a73F/w1h92X eOUflIhsWduzvRWUiiCB400xPFFA6MlqKJtrw4L4tMWoXGKaaQUUYkaXsbww7C5vT2gd GuONn3WtWBlTjLkioSLVY9UpXLtFbHqbmWmKug4aHfP1VWQ582PCbYcMevBak0W9/HLL UHx2yX8pXZkXDeqK+j2Texja2MJEz/7+Zbg0mBQ0SzsPfuEL6WpB8gOan+54r5pBlidg wUTT7Cr3LFDqUt6raNMOix6D8wSFyETzNPUh2hft3F/xQJr4WIHI/I7ULXWppOG6JqDZ oItQ== X-Gm-Message-State: AOAM531tbhhlEJ0L9xWbk2yWpeu6pSspSgkZME9z4pjhx/j/K6ukZOjX +2VIkGU2EnGClyusetgsR3ssFA== X-Google-Smtp-Source: ABdhPJz0asluo8iIS9RrrQHu2lUE14mBYhmmL4kxvHAkUj2TEWV/p8/NhGuQnU8TsBWnkNPOevvXaQ== X-Received: by 2002:a17:902:f787:b0:14f:43ba:55fc with SMTP id q7-20020a170902f78700b0014f43ba55fcmr979111pln.3.1645067279683; Wed, 16 Feb 2022 19:07:59 -0800 (PST) Received: from [192.168.1.100] ([198.8.77.157]) by smtp.gmail.com with ESMTPSA id lb18sm407819pjb.42.2022.02.16.19.07.57 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 16 Feb 2022 19:07:59 -0800 (PST) Message-ID: <2f3f1c98-e013-ee03-2ffb-3a14730b13b9@kernel.dk> Date: Wed, 16 Feb 2022 20:07:56 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux aarch64; rv:91.0) Gecko/20100101 Thunderbird/91.5.1 Subject: Re: remove REQ_OP_WRITE_SAME v2 Content-Language: en-US To: Christoph Hellwig , "Martin K. Petersen" Cc: philipp.reisner@linbit.com, lars.ellenberg@linbit.com, target-devel@vger.kernel.org, haris.iqbal@ionos.com, jinpu.wang@ionos.com, manoj@linux.ibm.com, mrochs@linux.ibm.com, ukrishn@linux.ibm.com, linux-block@vger.kernel.org, linux-scsi@vger.kernel.org, drbd-dev@lists.linbit.com, dm-devel@redhat.com References: <20220209082828.2629273-1-hch@lst.de> <20220210055151.GA3491@lst.de> From: Jens Axboe In-Reply-To: <20220210055151.GA3491@lst.de> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org On 2/9/22 10:51 PM, Christoph Hellwig wrote: > On Wed, Feb 09, 2022 at 01:00:26PM -0500, Martin K. Petersen wrote: >> >> Christoph, >> >>> Now that we are using REQ_OP_WRITE_ZEROES for all zeroing needs in the >>> kernel there is very little use left for REQ_OP_WRITE_SAME. We only >>> have two callers left, and both just export optional protocol features >>> to remote systems: DRBD and the target code. >> >> No particular objections from me. I had a half-baked series to do the >> same thing. >> >> One thing I would like is to either pull this series through SCSI or do >> the block pieces in a post merge branch because I'm about to post my >> discard/zeroing rework and that's going to clash with your changes. > > I'd be fine with taking this through the SCSI tree. Or we can wait > another merge window to make your life easier. Let's just use the SCSI tree - I didn't check if it throws any conflicts right now, so probably something to check upfront... If things pan out, you can add my Acked-by to the series. -- Jens Axboe