Linux SCSI subsystem development
 help / color / mirror / Atom feed
From: "Ariel Otilibili-Anieli" <Ariel.Otilibili-Anieli@eurecom.fr>
To: "Ariel Otilibili" <ariel.otilibili-anieli@eurecom.fr>
Cc: linux-scsi@vger.kernel.org, "Hannes Reinecke" <hare@kernel.org>,
	"James E.J. Bottomley" <James.Bottomley@HansenPartnership.com>,
	"Martin K. Petersen" <martin.petersen@oracle.com>
Subject: [PING] drivers/scsi: remove dead code
Date: Thu, 19 Dec 2024 00:59:27 +0100	[thread overview]
Message-ID: <2f7a86-67636200-8e2f-26131fc0@196789333> (raw)
In-Reply-To: <20241213225852.62741-2-ariel.otilibili-anieli@eurecom.fr>

Hello,

Is there any news of the patch? Your feedback is much appreciated.

Have a good day,
Ariel

On Friday, December 13, 2024 23:57 CET, Ariel Otilibili <ariel.otilibili-anieli@eurecom.fr> wrote:

> * reported by Coverity ID 1602240
> * ldev_info is always true, therefore the branch statement is never called.
> 
> Fixes: 081ff398c56cc ("scsi: myrb: Add Mylex RAID controller (block interface)")
> Cc: Hannes Reinecke <hare@kernel.org>
> Cc: "James E.J. Bottomley" <James.Bottomley@HansenPartnership.com>
> Cc: "Martin K. Petersen" <martin.petersen@oracle.com>
> Signed-off-by: Ariel Otilibili <ariel.otilibili-anieli@eurecom.fr>
> ---
>  drivers/scsi/myrb.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/scsi/myrb.c b/drivers/scsi/myrb.c
> index 363d71189cfe..dc4bd422b601 100644
> --- a/drivers/scsi/myrb.c
> +++ b/drivers/scsi/myrb.c
> @@ -1627,8 +1627,6 @@ static int myrb_ldev_sdev_init(struct scsi_device *sdev)
>  	enum raid_level level;
>  
>  	ldev_info = cb->ldev_info_buf + ldev_num;
> -	if (!ldev_info)
> -		return -ENXIO;
>  
>  	sdev->hostdata = kzalloc(sizeof(*ldev_info), GFP_KERNEL);
>  	if (!sdev->hostdata)
> -- 
> 2.47.1
>


  reply	other threads:[~2024-12-18 23:59 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-12-13 22:57 [PATCH 0/1] drivers/scsi: remove dead code Ariel Otilibili
2024-12-13 22:57 ` [PATCH 1/1] " Ariel Otilibili
2024-12-18 23:59   ` Ariel Otilibili-Anieli [this message]
2025-01-02 18:50   ` Martin K. Petersen
2025-01-02 21:25     ` Ariel Otilibili-Anieli
2025-01-02 22:51       ` Martin K. Petersen
2025-01-03  0:47         ` Ariel Otilibili-Anieli
2025-01-10 21:16   ` Martin K. Petersen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2f7a86-67636200-8e2f-26131fc0@196789333 \
    --to=ariel.otilibili-anieli@eurecom.fr \
    --cc=James.Bottomley@HansenPartnership.com \
    --cc=hare@kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=martin.petersen@oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox