Linux SCSI subsystem development
 help / color / mirror / Atom feed
From: "Peter Wang (王信友)" <peter.wang@mediatek.com>
To: "powenkao@google.com" <powenkao@google.com>
Cc: "beanhuo@micron.com" <beanhuo@micron.com>,
	"avri.altman@wdc.com" <avri.altman@wdc.com>,
	"quic_nguyenb@quicinc.com" <quic_nguyenb@quicinc.com>,
	"linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
	"bvanassche@acm.org" <bvanassche@acm.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"alim.akhtar@samsung.com" <alim.akhtar@samsung.com>,
	"adrian.hunter@intel.com" <adrian.hunter@intel.com>,
	"mani@kernel.org" <mani@kernel.org>,
	"James.Bottomley@hansenpartnership.com"
	<James.Bottomley@hansenpartnership.com>,
	"martin.petersen@oracle.com" <martin.petersen@oracle.com>
Subject: Re: [PATCH 1/1] scsi: ufs: core: Fix EH failure after wlun resume error
Date: Wed, 19 Nov 2025 09:18:09 +0000	[thread overview]
Message-ID: <301cc0724a9e22bf195cb0bafb0c5d298e93e99d.camel@mediatek.com> (raw)
In-Reply-To: <CA+=0d2aYn_q=i6Yy=zSu6eE=Fj0oTk4t00e1uezBxqNc5E7pdg@mail.gmail.com>

On Tue, 2025-11-18 at 15:26 +0800, Brian Kao wrote
> 
> Hi Peter,
> 
> Sorry that I didn't mention that this is in the resume path.
> The resume flow in bellow will re-enable IRQ and go through full
> re-initialization which potentially trigger issue I described
> previously
> ```
> ufshcd_resume()
>     ufshcd_enable_irq(hba);
> ufshcd_wl_resume()
>     ufshcd_reset_and_restore()                            <== depends
> on PM level
>         ufshcd_hba_enable()
>         ufshcd_probe_hba()
>     ufshcd_set_dev_pwr_mode(hba, UFS_ACTIVE_PWR_MODE);    <== EH is
> scheduled before this point
>     ....
> ```

Hi Brian,

You mean that the suspend level sets the link to off, and then
ufshcd_reset_and_restore encounters an error during the resume 
flow, right? This does seem to be a potential issue.

Thanks
Peter


  reply	other threads:[~2025-11-19  9:18 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-11-12  6:32 [PATCH 1/1] scsi: ufs: core: Fix EH failure after wlun resume error Po-Wen Kao
2025-11-12  8:17 ` Peter Wang (王信友)
     [not found]   ` <CA+=0d2YnrDL41DXtC8kDmtXioy4+hohGsmrOPxJY31jqt22uww@mail.gmail.com>
2025-11-12  9:29     ` Brian Kao
2025-11-13 10:06     ` Peter Wang (王信友)
2025-11-18  7:26       ` Brian Kao
2025-11-19  9:18         ` Peter Wang (王信友) [this message]
2025-11-19 23:44           ` Brian Kao
2025-11-20 13:14             ` Peter Wang (王信友)
2025-11-20 16:32 ` Bart Van Assche
2025-11-29 20:02 ` Martin K. Petersen
2025-12-09  3:21 ` Martin K. Petersen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=301cc0724a9e22bf195cb0bafb0c5d298e93e99d.camel@mediatek.com \
    --to=peter.wang@mediatek.com \
    --cc=James.Bottomley@hansenpartnership.com \
    --cc=adrian.hunter@intel.com \
    --cc=alim.akhtar@samsung.com \
    --cc=avri.altman@wdc.com \
    --cc=beanhuo@micron.com \
    --cc=bvanassche@acm.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=mani@kernel.org \
    --cc=martin.petersen@oracle.com \
    --cc=powenkao@google.com \
    --cc=quic_nguyenb@quicinc.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox