From: Bart Van Assche <bvanassche@acm.org>
To: Salomon Dushimirimana <salomondush@google.com>,
Sathya Prakash Veerichetty <sathya.prakash@broadcom.com>,
Kashyap Desai <kashyap.desai@broadcom.com>,
Sumit Saxena <sumit.saxena@broadcom.com>,
Sreekanth Reddy <sreekanth.reddy@broadcom.com>,
"James E.J. Bottomley" <James.Bottomley@HansenPartnership.com>,
"Martin K. Petersen" <martin.petersen@oracle.com>
Cc: mpi3mr-linuxdrv.pdl@broadcom.com, linux-scsi@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] scsi: mpi3mr: Emit uevent on controller diagnostic fault
Date: Wed, 16 Jul 2025 08:51:04 -0700 [thread overview]
Message-ID: <30f8ea8d-79c4-4e5c-b354-51ad8146a61c@acm.org> (raw)
In-Reply-To: <20250716013103.1571029-1-salomondush@google.com>
On 7/15/25 6:31 PM, Salomon Dushimirimana wrote:
> + ioc_info(mrioc, "emitting fault exception uevent");
Is it really necessary to log that a uevent will be emitted?
> +exit:
> + kfree(env);
> +}
Why an explicit kfree() call instead of adding __free(kfree) to
the declaration of "env"?
Thanks,
Bart.
next prev parent reply other threads:[~2025-07-16 15:51 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-16 1:31 [PATCH] scsi: mpi3mr: Emit uevent on controller diagnostic fault Salomon Dushimirimana
2025-07-16 15:51 ` Bart Van Assche [this message]
2025-07-17 19:40 ` [PATCH v2] " Salomon Dushimirimana
2025-07-18 15:43 ` Sathya Prakash Veerichetty
2025-07-18 23:31 ` Salomon Dushimirimana
2025-07-21 15:45 ` Sathya Prakash Veerichetty
2025-07-31 15:45 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=30f8ea8d-79c4-4e5c-b354-51ad8146a61c@acm.org \
--to=bvanassche@acm.org \
--cc=James.Bottomley@HansenPartnership.com \
--cc=kashyap.desai@broadcom.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=mpi3mr-linuxdrv.pdl@broadcom.com \
--cc=salomondush@google.com \
--cc=sathya.prakash@broadcom.com \
--cc=sreekanth.reddy@broadcom.com \
--cc=sumit.saxena@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).