* megaraid_sas dbg_lvl permissions [not found] <25702243.1118401218748366053.JavaMail.root@ouachita> @ 2008-08-14 21:14 ` Joe Malicki 2008-08-15 14:44 ` Yang, Bo 0 siblings, 1 reply; 2+ messages in thread From: Joe Malicki @ 2008-08-14 21:14 UTC (permalink / raw) To: Bo Yang; +Cc: linux-scsi /sys/bus/pci/drivers/megaraid_sas/dbg_lvl defaults to being world-writable, which seems bad (letting any user affect kernel driver behavior and logging level). This turns off group and user write permissions, so that on typical production systems only root can write to it. Signed-off-by: Joseph Malicki <jmalicki@metacarta.com> -- --- drivers/scsi/megaraid/megaraid_sas.c.orig 2008-01-31 10:49:57.000000000 -0500 +++ drivers/scsi/megaraid/megaraid_sas.c 2008-01-31 10:52:10.000000000 -0500 @@ -3044,7 +3044,7 @@ return retval; } -static DRIVER_ATTR(dbg_lvl, S_IRUGO|S_IWUGO, megasas_sysfs_show_dbg_lvl, +static DRIVER_ATTR(dbg_lvl, S_IRUGO|S_IWUSR, megasas_sysfs_show_dbg_lvl, megasas_sysfs_set_dbg_lvl); /** -- ^ permalink raw reply [flat|nested] 2+ messages in thread
* RE: megaraid_sas dbg_lvl permissions 2008-08-14 21:14 ` megaraid_sas dbg_lvl permissions Joe Malicki @ 2008-08-15 14:44 ` Yang, Bo 0 siblings, 0 replies; 2+ messages in thread From: Yang, Bo @ 2008-08-15 14:44 UTC (permalink / raw) To: Joe Malicki; +Cc: linux-scsi@vger.kernel.org ACK. Thanks, Bo Yang -----Original Message----- From: Joe Malicki [mailto:jmalicki@metacarta.com] Sent: Thursday, August 14, 2008 5:15 PM To: Yang, Bo Cc: linux-scsi@vger.kernel.org Subject: megaraid_sas dbg_lvl permissions /sys/bus/pci/drivers/megaraid_sas/dbg_lvl defaults to being world-writable, which seems bad (letting any user affect kernel driver behavior and logging level). This turns off group and user write permissions, so that on typical production systems only root can write to it. Signed-off-by: Joseph Malicki <jmalicki@metacarta.com> -- --- drivers/scsi/megaraid/megaraid_sas.c.orig 2008-01-31 10:49:57.000000000 -0500 +++ drivers/scsi/megaraid/megaraid_sas.c 2008-01-31 10:52:10.000000000 -0500 @@ -3044,7 +3044,7 @@ return retval; } -static DRIVER_ATTR(dbg_lvl, S_IRUGO|S_IWUGO, megasas_sysfs_show_dbg_lvl, +static DRIVER_ATTR(dbg_lvl, S_IRUGO|S_IWUSR, +megasas_sysfs_show_dbg_lvl, megasas_sysfs_set_dbg_lvl); /** -- ^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2008-08-15 14:45 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <25702243.1118401218748366053.JavaMail.root@ouachita>
2008-08-14 21:14 ` megaraid_sas dbg_lvl permissions Joe Malicki
2008-08-15 14:44 ` Yang, Bo
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox