From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from 013.lax.mailroute.net (013.lax.mailroute.net [199.89.1.16]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3C09C379EE4; Mon, 20 Apr 2026 16:58:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=199.89.1.16 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776704314; cv=none; b=pVpC8l0yeZsIH5r+cqhK/DP3hiHpv27IwAIXPkHwSJllZ/O/aPqkFi4MXWpcebArGhIrjZq4mMGfWwygOabKPbYZDc12MxIVb+zfQC/hsnp3azQA36z+VOR9U9AMJfkNX82KEmJ3Ao7EiHk3JRt/aIOjM0iHy1sHt2a8+oZlJ3I= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776704314; c=relaxed/simple; bh=267J5lYVPfOLIkD3IZTERG2XE+VdX0sx6jwHWEYbSQo=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=b+lK+4lBvhnifaMnBsZ53UsimKK7GY32NfcCd9+UoMUWcRv1Hc5PEVAxUl8pfByHPNF3dtHwByzNMi/AnW6h987g4z4OqxHwrIE8CuT4iYu15i7RkHLq/5ieT83y3d+GGQ5SOYu8Nl/7lFg5d5GDm8rwHlEKssmc4Nwt+RMO4NU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=acm.org; spf=pass smtp.mailfrom=acm.org; dkim=pass (2048-bit key) header.d=acm.org header.i=@acm.org header.b=byblWIv0; arc=none smtp.client-ip=199.89.1.16 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=acm.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=acm.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=acm.org header.i=@acm.org header.b="byblWIv0" Received: from localhost (localhost [127.0.0.1]) by 013.lax.mailroute.net (Postfix) with ESMTP id 4fzsBc4tyBzlffvG; Mon, 20 Apr 2026 16:58:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=acm.org; h= content-transfer-encoding:content-type:content-type:in-reply-to :from:from:content-language:references:subject:subject :user-agent:mime-version:date:date:message-id:received:received; s=mr01; t=1776704304; x=1779296305; bh=dLYm+DhUaFyrsv2woamzU3QH TCSe9i0NP8QlYYjwjzI=; b=byblWIv0P0Ebkw4JlwOgYqTaYD7Pkbhr07rvOBeU eqeM+CmpALZZYsIa0GDaYsQJRnJegqb8jXa0/o1yYugdkbEDRuc7Zkzcvm1IjSXY WtVp+fEGbPvDG6mrjczGhF1wWqncFRVLH49iH29I4EFHhiq+eko7l5XxsaCHzxc4 GZILKBBB+QNsBD413ToTZAqKt52TMVOEDU4chhqQyrd6StD7QXm2NuYqYwXqI7tg 0mgKwSteRw6/D7GYeHJZRZowSRp4zwozakvOaf3EHkakZDJAd5ylD2tkrBV5cUKf Fc2jFObQEFqUdZAYACBI1OS5NLzkIuAs1qYIpgf4UQd2XA== X-Virus-Scanned: by MailRoute Received: from 013.lax.mailroute.net ([127.0.0.1]) by localhost (013.lax [127.0.0.1]) (mroute_mailscanner, port 10029) with LMTP id FkTLZVA9wyJe; Mon, 20 Apr 2026 16:58:24 +0000 (UTC) Received: from [100.119.48.131] (unknown [104.135.180.219]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: bvanassche@acm.org) by 013.lax.mailroute.net (Postfix) with ESMTPSA id 4fzsBM61JJzlgtd1; Mon, 20 Apr 2026 16:58:19 +0000 (UTC) Message-ID: <316c8b28-9e93-4d14-b6d6-e8d593b8627c@acm.org> Date: Mon, 20 Apr 2026 09:58:18 -0700 Precedence: bulk X-Mailing-List: linux-scsi@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/2] scsi: ufs: core: Introduce function ufshcd_query_attr_qword() To: Can Guo , avri.altman@wdc.com, beanhuo@micron.com, peter.wang@mediatek.com, martin.petersen@oracle.com, mani@kernel.org Cc: linux-scsi@vger.kernel.org, Alim Akhtar , "James E.J. Bottomley" , Keoseong Park , Daniel Lee , Ram Kumar Dwivedi , Huan Tang , Liu Song , Bean Huo , vamshi gajjela , "Rafael J. Wysocki" , Adrian Hunter , open list References: <20260419135229.1036926-1-can.guo@oss.qualcomm.com> <20260419135229.1036926-2-can.guo@oss.qualcomm.com> Content-Language: en-US From: Bart Van Assche In-Reply-To: <20260419135229.1036926-2-can.guo@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 4/19/26 6:52 AM, Can Guo wrote: > +static inline bool ufshcd_is_qword_attrs(enum attr_idn idn) > +{ > + return idn == QUERY_ATTR_IDN_TIMESTAMP || > + idn == QUERY_ATTR_IDN_DEV_LVL_EXCEPTION_ID; > +} Please change "ufshcd_is_qword_attrs()" into "ufshcd_is_qword_attr()". > +/** > + * ufshcd_query_attr_qword - API function of sending query requests for quad-word attributes > + * @hba: per-adapter instance > + * @opcode: attribute opcode > + * @idn: attribute idn to access > + * @index: index field > + * @sel: selector field > + * @attr_val: the attribute value after the query request completes > + * > + * Return: 0 for success, non-zero in case of failure. > + */ The word "API" is uncommon in the first line of kernel-doc headers. Please remove it. Otherwise this patch looks good to me. Thanks, Bart.