Re: [PATCH 2/2] scsi: ufs: core: Add support to retrieve and store TX Equalization settings

Can Guo
2026-04-23T13:50:17Z

On 4/21/2026 1:01 AM, Bart Van Assche wrote:
> On 4/19/26 6:52 AM, Can Guo wrote:
>> +#define TX_EQ_DEVICE_PRESHOOT_DECODE(eq, lane) \
>> +    (((eq) >> ((lane) * TX_HS_PRESHOOT_SHIFT)) & TX_EQ_SETTING_MASK)
>> +#define TX_EQ_DEVICE_DEEMPHASIS_DECODE(eq, lane) \
>> +    (((eq) >> ((lane) * TX_HS_DEEMPHASIS_SHIFT + 16)) &
>> TX_EQ_SETTING_MASK)
>
> Please convert these two macros and also all the other new macros in
> this patch that accept arguments into inline functions.
Will do.

Thanks,
Can Guo.
>
> Thanks,
>
> Bart.