From: Bart Van Assche <bvanassche@acm.org>
To: "Peter Wang (王信友)" <peter.wang@mediatek.com>,
"martin.petersen@oracle.com" <martin.petersen@oracle.com>
Cc: "linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
"beanhuo@micron.com" <beanhuo@micron.com>,
"can.guo@oss.qualcomm.com" <can.guo@oss.qualcomm.com>,
"avri.altman@sandisk.com" <avri.altman@sandisk.com>,
"James.Bottomley@HansenPartnership.com"
<James.Bottomley@HansenPartnership.com>,
"adrian.hunter@intel.com" <adrian.hunter@intel.com>
Subject: Re: [PATCH 3/3] ufs: core: Optimize ufshcd_add_uic_command_trace()
Date: Tue, 21 Apr 2026 12:37:16 -0700 [thread overview]
Message-ID: <31c4e534-80e1-455d-8057-8b71a7616de5@acm.org> (raw)
In-Reply-To: <a186b02b00694be3e89cd49d477c050df4bb1cf5.camel@mediatek.com>
On 4/21/26 1:45 AM, Peter Wang (王信友) wrote:
> In the complete case, all these commands and arguments 1 to 3
> are filled by hardware. If we do not read them from the hardware,
> how can we be sure of the actual values written by the hardware?
Hi Peter,
Are we perhaps each interpreting the UFSHCI standard in a different way?
My understanding is that the UFSHCI command flow is as follows:
* First, UICCMDARG1, UICCMDARG2 and UICCMDARG3 are written by the host.
* Next, UICCMD is written by the host. This causes the host controller
to execute the UIC command.
* Upon completion of the command, the host controller updates the lowest
byte of UICCMDARG2. UICCMDARG3 is only updated after execution of the
following commands has finished: DME_GET, DME_SET, DME_PEER_GET and
DME_PEER_SET.
Thanks,
Bart.
next prev parent reply other threads:[~2026-04-21 19:37 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-17 21:30 [PATCH 0/3] ufs: core: Optimize the UIC command implementation Bart Van Assche
2026-04-17 21:30 ` [PATCH 1/3] ufs: core: Inline two functions related to UIC commands Bart Van Assche
2026-04-21 8:41 ` Peter Wang (王信友)
2026-04-17 21:30 ` [PATCH 2/3] ufs: core: Complain if UIC argument 2 is invalid Bart Van Assche
2026-04-21 8:42 ` Peter Wang (王信友)
2026-04-17 21:30 ` [PATCH 3/3] ufs: core: Optimize ufshcd_add_uic_command_trace() Bart Van Assche
2026-04-21 8:45 ` Peter Wang (王信友)
2026-04-21 19:37 ` Bart Van Assche [this message]
2026-04-22 7:52 ` Peter Wang (王信友)
2026-04-22 16:30 ` Bart Van Assche
2026-04-23 8:08 ` Peter Wang (王信友)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=31c4e534-80e1-455d-8057-8b71a7616de5@acm.org \
--to=bvanassche@acm.org \
--cc=James.Bottomley@HansenPartnership.com \
--cc=adrian.hunter@intel.com \
--cc=avri.altman@sandisk.com \
--cc=beanhuo@micron.com \
--cc=can.guo@oss.qualcomm.com \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=peter.wang@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox