RE: [PATCH RESEND 6/18] megaraid_sas : Use Block layer tag support for internal command indexing

[Sumit Saxena <sumit.saxena@avagotech.com>]

>-----Original Message-----
>From: Sumit Saxena [mailto:sumit.saxena@avagotech.com]
>Sent: Tuesday, April 21, 2015 6:03 PM
>To: 'Christoph Hellwig'
>Cc: 'linux-scsi@vger.kernel.org'; 'thenzl@redhat.com';
>'martin.petersen@oracle.com'; 'jbottomley@parallels.com'; Kashyap Desai
>Subject: RE: [PATCH RESEND 6/18] megaraid_sas : Use Block layer tag
support
>for internal command indexing
>
>
>
>>-----Original Message-----
>>From: Christoph Hellwig [mailto:hch@infradead.org]
>>Sent: Tuesday, April 21, 2015 4:12 PM
>>To: Sumit.Saxena@avagotech.com
>>Cc: linux-scsi@vger.kernel.org; thenzl@redhat.com;
>>martin.petersen@oracle.com; hch@infradead.org;
>>jbottomley@parallels.com; kashyap.desai@avagotech.com
>>Subject: Re: [PATCH RESEND 6/18] megaraid_sas : Use Block layer tag
>>support for internal command indexing
>>
>>This patch needs to be split up:  the return_cmd calling convenion
>>changes should be a pach on it's own, the various new debug printks
>>should be a patch on their own, or better jsut be dropped.
>
>I can work on this. Logically, there can be two patches- 1) BLK tag
support 2)
>changes in calling convention of return_cmd (this patch will revert the
changes
>done by patch- 90dc9d9 megaraid_sas : MFI MPT linked list corruption
fix).
>So patch #2 will be very much dependent on patch #1. If someone applies
>patch #2 without applying patch#1, then bug fixed by  "90dc9d9
megaraid_sas
>: MFI MPT linked list corruption fix " will be exposed again.
>That's why I club these two patches in a single patch. Regarding debug
prints,
>that can be removed.

Christoph,
I have started rework for the patches. I will remove debug printks. Can
you please let me know should I go for separate patch for change in
calling convention return_cmd?

Thanks,
Sumit
>>
>>Also please drop the BLK_TAG_REFCOUNT/DEBUG code that shouldn't be
>ina
>>production driver.