Re: [EXT] Re: [PATCH v2] ufs: core: Add WB buffer resize support

[Bean Huo <huobean@gmail.com>]

On Tue, 2024-10-29 at 11:11 +0800, Huan Tang wrote:
> > On 10/28/24 1:04 PM, Bean Huo wrote:
> > > Even though I don't think it's necessary to enable a Sysfs node
> > > entry
> > > for this configuration.
> > 
> > Right, a motivation of why this functionality should be available
> > in sysfs is
> > missing. An explanation should be added in the patch description.
> > 
> > Thanks,
> > 
> > Bart.
> 
> Hi Bean & Bart,
> 
> Motivation: Through the sysfs upper layer code, the WB resize
> function can be used in some scenarios, or related information can be
> obtained indirectly to implement different strategies;
> What is your suggestion? sysfs? exception event? or?
> 
> Thanks
> Huan

hey Huan,

What specific scenarios would require enabling a sysfs node to control
this function? Dynamically adjusting the WriteBooster (WB) size on the
fly doesn’t seem ideal to me. From my perspective, the main case for
this feature is if the OEM didn’t correctly define or set the
WriteBooster Buffer size during manufacturing. Even then, adjusting the
WB buffer size wouldn’t be a frequent need. If JEDEC has found a reason
for this feature to be accepted, isn’t there already an interface
available to configure it? Why would we need a duplicate interface for
the same purpose?

Kind regards,
Bean