public inbox for linux-scsi@vger.kernel.org
 help / color / mirror / Atom feed
From: "Justin T. Gibbs" <gibbs@scsiguy.com>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>,
	James Bottomley <James.Bottomley@SteelEye.com>
Cc: SCSI Mailing List <linux-scsi@vger.kernel.org>,
	Linus Torvalds <torvalds@transmeta.com>,
	Marcelo Tosatti <marcelo@conectiva.com.br>,
	Andrew Morton <akpm@osdl.org>
Subject: Re: Aic7x_x_x 6.3.4 && Aic79xx 2.0.5 Updates
Date: Sat, 27 Dec 2003 09:02:12 -0700	[thread overview]
Message-ID: <3334920000.1072540932@aslan.btc.adaptec.com> (raw)
In-Reply-To: <1072538231.5494.12.camel@dhcp23.swansea.linux.org.uk>

> Or install your own EH handler.

This was something I considered, but is sadly not enough.  You need
at least two other changes to make it work:

1) scsi_done needs to complete commands regardless of the timer
   state.  The implied race condition commented about in scsi_done()
   doesn't exist.  The HBA driver knows whether a command is in flight
   or not.  Attempting to abort a command that is not active can just
   return immediately with whatever status is agreed upon for the API.
   Without this change, a driver must reschedule bogus timers to get
   a completion to take effect.

2) The driver's must be notified of timeouts immediately.  Your idea
   of re-vectoring the timeout handler would do this just fine.

--
Justin


      parent reply	other threads:[~2003-12-27 15:56 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-06-03 23:51 (unknown) Justin T. Gibbs
2003-06-03 23:58 ` Marc-Christian Petersen
2003-06-04  1:34 ` Aic7x_x_x 6.2.36 && Aic79xx 1.3.10 Updates Justin T. Gibbs
2003-12-24 16:58   ` Aic7x_x_x 6.3.4 && Aic79xx 2.0.5 Updates Justin T. Gibbs
2003-12-24 17:50     ` James Bottomley
     [not found]       ` <2148850000.1072292121@aslan.scsiguy.com>
2003-12-24 19:05         ` James Bottomley
2003-12-25  4:31           ` Justin T. Gibbs
2003-12-26 18:36             ` James Bottomley
2003-12-27  0:13               ` Justin T. Gibbs
2003-12-27  3:20                 ` James Bottomley
2003-12-27  4:26                   ` Justin T. Gibbs
2003-12-27  6:08                     ` Jeff Garzik
2003-12-27 15:11                     ` Alan Cox
2003-12-27 15:47                       ` Justin T. Gibbs
2003-12-27 15:52                     ` James Bottomley
2003-12-27 15:17               ` Alan Cox
2003-12-27 15:54                 ` James Bottomley
2003-12-27 23:55                   ` Alan Cox
2003-12-27 16:02                 ` Justin T. Gibbs [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3334920000.1072540932@aslan.btc.adaptec.com \
    --to=gibbs@scsiguy.com \
    --cc=James.Bottomley@SteelEye.com \
    --cc=akpm@osdl.org \
    --cc=alan@lxorguk.ukuu.org.uk \
    --cc=linux-scsi@vger.kernel.org \
    --cc=marcelo@conectiva.com.br \
    --cc=torvalds@transmeta.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox