RE: RE: [RFC PATCH 0/5] scsi: ufs: Add Host Performance Booster Support

Avri Altman
2020-06-09T07:00:45Z

> > Like Bart, I am not sure that this extra module is needed.
> > It only makes sense if indeed there are some common calls that can be
> shared by several features.
> > There are up to now 10 extended features defined, but none of them can
> share a common api.
> > What other features can share this additional layer? And how those ops
> can be reused?
> > If you have some future implementations in mind, you should add this api
> once you'll add those.
> We added UFS feature layer with several callbacks to important parts of the
> UFS control flow.
> Other extended features can also be implemented using the proposed APIs.
> For example, in WB, "prep_fn" can be used to guarantee the lifetime of UFS
> by updating the amount of write IO used as WB.
This is an interesting idea.

> And reset/reset_host/suspend/resume can be used to manage the kernel task
> for checking lifetime of UFS.
Another interesting idea.

Fair enough. Please share in the commit log of patch 2/5 your plans,
Otherwise, just for HPB - It seems excessive.