From: "Asutosh Das (asd)" <asutoshd@codeaurora.org>
To: Bean Huo <huobean@gmail.com>,
alim.akhtar@samsung.com, avri.altman@wdc.com, jejb@linux.ibm.com,
martin.petersen@oracle.com, stanley.chu@mediatek.com,
beanhuo@micron.com, bvanassche@acm.org, tomas.winkler@intel.com,
cang@codeaurora.org
Cc: linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 6/8] scsi: ufs: Delete is_init_prefetch from struct ufs_hba
Date: Mon, 20 Jan 2020 12:43:09 -0800 [thread overview]
Message-ID: <34128bac-3811-16c1-ea6a-57c52cd70982@codeaurora.org> (raw)
In-Reply-To: <20200120130820.1737-7-huobean@gmail.com>
On 1/20/2020 5:08 AM, Bean Huo wrote:
> From: Bean Huo <beanhuo@micron.com>
>
> Without variable is_init_prefetch, the current logic can guarantee
> ufshcd_init_icc_levels() will execute only once, delete it now.
>
> Signed-off-by: Bean Huo <beanhuo@micron.com>
> ---
Reviewed-by: Asutosh Das <asutoshd@codeaurora.org>
> drivers/scsi/ufs/ufshcd.c | 5 +----
> drivers/scsi/ufs/ufshcd.h | 2 --
> 2 files changed, 1 insertion(+), 6 deletions(-)
>
> diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c
> index 3d3289bb3cad..0c859f239d1c 100644
> --- a/drivers/scsi/ufs/ufshcd.c
> +++ b/drivers/scsi/ufs/ufshcd.c
> @@ -6967,8 +6967,7 @@ static int ufshcd_add_lus(struct ufs_hba *hba)
> {
> int ret;
>
> - if (!hba->is_init_prefetch)
> - ufshcd_init_icc_levels(hba);
> + ufshcd_init_icc_levels(hba);
>
> /* Add required well known logical units to scsi mid layer */
> ret = ufshcd_scsi_add_wlus(hba);
> @@ -6994,8 +6993,6 @@ static int ufshcd_add_lus(struct ufs_hba *hba)
> scsi_scan_host(hba->host);
> pm_runtime_put_sync(hba->dev);
>
> - if (!hba->is_init_prefetch)
> - hba->is_init_prefetch = true;
> out:
> return ret;
> }
> diff --git a/drivers/scsi/ufs/ufshcd.h b/drivers/scsi/ufs/ufshcd.h
> index 32b6714f25a5..5c65d9fdeb14 100644
> --- a/drivers/scsi/ufs/ufshcd.h
> +++ b/drivers/scsi/ufs/ufshcd.h
> @@ -501,7 +501,6 @@ struct ufs_stats {
> * @intr_mask: Interrupt Mask Bits
> * @ee_ctrl_mask: Exception event control mask
> * @is_powered: flag to check if HBA is powered
> - * @is_init_prefetch: flag to check if data was pre-fetched in initialization
> * @init_prefetch_data: data pre-fetched during initialization
> * @eh_work: Worker to handle UFS errors that require s/w attention
> * @eeh_work: Worker to handle exception events
> @@ -652,7 +651,6 @@ struct ufs_hba {
> u32 intr_mask;
> u16 ee_ctrl_mask;
> bool is_powered;
> - bool is_init_prefetch;
> struct ufs_init_prefetch init_prefetch_data;
>
> /* Work Queues */
>
--
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
Linux Foundation Collaborative Project
next prev parent reply other threads:[~2020-01-20 20:43 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-20 13:08 [PATCH v4 0/8] Use UFS device indicated maximum LU number Bean Huo
2020-01-20 13:08 ` [PATCH v4 1/8] scsi: ufs: Fix ufshcd_probe_hba() reture value in case ufshcd_scsi_add_wlus() fails Bean Huo
2020-01-20 13:08 ` [PATCH v4 2/8] scsi: ufs: Delete struct ufs_dev_desc Bean Huo
2020-01-20 13:08 ` [PATCH v4 3/8] scsi: ufs: Split ufshcd_probe_hba() based on its called flow Bean Huo
2020-01-20 20:35 ` Asutosh Das (asd)
2020-01-20 13:08 ` [PATCH v4 4/8] scsi: ufs: Move ufshcd_get_max_pwr_mode() to ufshcd_device_params_init() Bean Huo
2020-01-20 20:39 ` Asutosh Das (asd)
2020-01-20 13:08 ` [PATCH v4 5/8] scsi: ufs: Inline two functions into their callers Bean Huo
2020-01-20 20:41 ` Asutosh Das (asd)
2020-01-22 5:08 ` Bart Van Assche
2020-01-20 13:08 ` [PATCH v4 6/8] scsi: ufs: Delete is_init_prefetch from struct ufs_hba Bean Huo
2020-01-20 20:43 ` Asutosh Das (asd) [this message]
2020-01-22 5:13 ` Bart Van Assche
2020-01-22 10:13 ` [EXT] " Bean Huo (beanhuo)
2020-01-20 13:08 ` [PATCH v4 7/8] scsi: ufs: Add max_lu_supported in struct ufs_dev_info Bean Huo
2020-01-20 13:08 ` [PATCH v4 8/8] scsi: ufs: Use UFS device indicated maximum LU number Bean Huo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=34128bac-3811-16c1-ea6a-57c52cd70982@codeaurora.org \
--to=asutoshd@codeaurora.org \
--cc=alim.akhtar@samsung.com \
--cc=avri.altman@wdc.com \
--cc=beanhuo@micron.com \
--cc=bvanassche@acm.org \
--cc=cang@codeaurora.org \
--cc=huobean@gmail.com \
--cc=jejb@linux.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=stanley.chu@mediatek.com \
--cc=tomas.winkler@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox