From: Bart Van Assche <bvanassche@acm.org>
To: Damien Le Moal <dlemoal@kernel.org>,
"Martin K . Petersen" <martin.petersen@oracle.com>
Cc: linux-scsi@vger.kernel.org,
Mike Christie <michael.christie@oracle.com>,
"James E.J. Bottomley" <James.Bottomley@HansenPartnership.com>
Subject: Re: [PATCH 1/2] scsi: core: Retry passthrough commands if SCMD_RETRY_PASST_ON_UA is set
Date: Fri, 9 Aug 2024 12:35:57 -0700 [thread overview]
Message-ID: <358d8cd4-20bd-4f99-954e-ce3afd626b94@acm.org> (raw)
In-Reply-To: <cd94a0d4-6e6d-495c-aa17-d2d2c875604a@kernel.org>
On 8/9/24 8:40 AM, Damien Le Moal wrote:
> On 2024/08/07 13:32, Bart Van Assche wrote:
>> The SCSI core does not retry passthrough commands even if the SCSI device
>> reports a retryable unit attention condition. Support retrying in this case
>> by introducing the SCMD_RETRY_PASST_ON_UA flag.
>
> This flag is badly named since nowhere it is checked that the retry happens on
> UNIT ATTENTION. The retry may happen with other sense key as well, no ?
>
> So what about simply calling this: SCMD_RETRY_PASSTHROUGH ?
That sounds good to me. See also v2 of this patch series.
Thanks,
Bart.
next prev parent reply other threads:[~2024-08-09 19:36 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-07 20:32 [PATCH 0/2] Fix system resume for SCSI devices Bart Van Assche
2024-08-07 20:32 ` [PATCH 1/2] scsi: core: Retry passthrough commands if SCMD_RETRY_PASST_ON_UA is set Bart Van Assche
2024-08-09 15:40 ` Damien Le Moal
2024-08-09 19:35 ` Bart Van Assche [this message]
2024-08-07 20:32 ` [PATCH 2/2] sd: Retry START STOP UNIT commands in case of a unit attention Bart Van Assche
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=358d8cd4-20bd-4f99-954e-ce3afd626b94@acm.org \
--to=bvanassche@acm.org \
--cc=James.Bottomley@HansenPartnership.com \
--cc=dlemoal@kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=michael.christie@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox