Re: [PATCH 4/6] scsi: libsas: remove useless dev_list delete in sas_ex_discover_end_dev()

Jason Yan
2022-12-08T11:12:11Z

On 2022/12/8 18:40, John Garry wrote:
> On 08/12/2022 07:21, Jason Yan wrote:
>>>> t_list_del:
>>>>       sas_rphy_free(child->rphy);
>>>>       list_del(&child->disco_list_node);
>>>> -    spin_lock_irq(&parent->port->dev_list_lock);
>>>> -    list_del(&child->dev_list_node);
>>>> -    spin_unlock_irq(&parent->port->dev_list_lock);
>>>
>>> Since we have the spin lock'ing, this seems to be have been
>>> intentionally added (and not some simple typo or similar) - any idea
>>> of the origin?
>>
>> The new device used to be added to the dev_list in this function. But
>> after 92625f9bff38 ("[SCSI] libsas: restore scan order") and
>> 87c8331fcf72 ("[SCSI] libsas: prevent domain rediscovery competing
>> with ata error handling") it is added to the disco_list instead. But
>> the list_del() and locking is forgot to be removed.
>
> OK, so can we have a fixes tag then? That even helps review, as I can
> then quickly see where we went wrong.
>

Sure.

Thanks,
Jason