public inbox for linux-scsi@vger.kernel.org
 help / color / mirror / Atom feed
From: Mike Christie <michael.christie@oracle.com>
To: Yang Li <yang.lee@linux.alibaba.com>, martin.petersen@oracle.com
Cc: linux-scsi@vger.kernel.org, target-devel@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	Abaci Robot <abaci@linux.alibaba.com>
Subject: Re: [PATCH -next] scsi: target: core: Fix one kernel-doc comment
Date: Tue, 17 Oct 2023 10:49:53 -0500	[thread overview]
Message-ID: <39261212-54e0-4990-a72e-ec66457cbdbd@oracle.com> (raw)
In-Reply-To: <20231017030913.89973-1-yang.lee@linux.alibaba.com>

On 10/16/23 10:09 PM, Yang Li wrote:
> Fix one kernel-doc comment to silence the warnings:
> drivers/target/target_core_transport.c:1930: warning: Excess function parameter 'cmd' description in 'target_submit'
> drivers/target/target_core_transport.c:1930: warning: Function parameter or member 'se_cmd' not described in 'target_submit'
> 
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=6844
> Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
> ---
>  drivers/target/target_core_transport.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/target/target_core_transport.c b/drivers/target/target_core_transport.c
> index c81def3c96df..670cfb7bd426 100644
> --- a/drivers/target/target_core_transport.c
> +++ b/drivers/target/target_core_transport.c
> @@ -1921,7 +1921,7 @@ static void target_queue_submission(struct se_cmd *se_cmd)
>  
>  /**
>   * target_submit - perform final initialization and submit cmd to LIO core
> - * @cmd: command descriptor to submit
> + * @se_cmd: command descriptor to submit
>   *
>   * target_submit_prep or something similar must have been called on the cmd,
>   * and this must be called from process context.

Thanks.

Reviewed-by: Mike Christie <michael.christie@oracle.com>

  reply	other threads:[~2023-10-17 15:50 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-10-17  3:09 [PATCH -next] scsi: target: core: Fix one kernel-doc comment Yang Li
2023-10-17 15:49 ` Mike Christie [this message]
2023-10-25  2:23 ` Martin K. Petersen
2023-10-30 15:34 ` Martin K. Petersen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=39261212-54e0-4990-a72e-ec66457cbdbd@oracle.com \
    --to=michael.christie@oracle.com \
    --cc=abaci@linux.alibaba.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=martin.petersen@oracle.com \
    --cc=target-devel@vger.kernel.org \
    --cc=yang.lee@linux.alibaba.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox