Re: Fwd: Patch - SCSI host numbers - please apply

Re: Fwd: Patch - SCSI host numbers - please apply

[Luben Tuikov]

[-- Attachment #1: Type: text/plain, Size: 2841 bytes --]

Itai,

After applying your patch to 2.4.18, I see the following
problems:

1. ide-scsi does NOT work. /proc/scsi/scsi shows NO
   devices and /proc/scsi/ide-scsi is empty.

2. /proc/scsi/{scsi, ide-scsi, scsi_test} are all empty!

3. After ``rmmod scsi_test'' and ``ls /proc/scsi''
   the kernel OOPS-es.

NONE of those problems exist with a non-patched kernel.

I used kernel 2.4.18, but doubt there'd difference for
2.5.x since the host_no stuff hasn't changed (2.5.22).

I've attached the OOPS and the tgz of my testing
module scsi_test.o.

Interested parties: this is in regards to the
scsi subsystem assigning _repeating_ host numbers
to hosts registered! See my message 
``/proc/scsi/driver/hosts with same numeric???''
dated 2002/05/29 on linux-scsi ML.

To repeat the problem:
$ insmod scsi_reg.o
$ rmmod scsi_reg
$ insmod scsi_req.o MaxHosts=20
$ ls /proc/scsi/scsi_test

Voila!

Here is the OOPS:
----------------------------
Jun 18 16:49:23 canoe kernel: Unable to handle kernel paging request at virtual address e5a59010
Jun 18 16:49:23 canoe kernel:  printing eip:
Jun 18 16:49:23 canoe kernel: c0150c68
Jun 18 16:49:23 canoe kernel: *pde = 1d58c067
Jun 18 16:49:23 canoe kernel: *pte = 00000000
Jun 18 16:49:23 canoe kernel: Oops: 0002
Jun 18 16:49:23 canoe kernel: CPU:    0
Jun 18 16:49:23 canoe kernel: EIP:    0010:[proc_get_inode+152/256]    Not tainted
Jun 18 16:49:23 canoe kernel: EIP:    0010:[<c0150c68>]    Not tainted
Jun 18 16:49:23 canoe kernel: EFLAGS: 00010286
Jun 18 16:49:23 canoe kernel: eax: e5a59000   ebx: dc921880   ecx: 00000001   edx: 00000003
Jun 18 16:49:23 canoe kernel: esi: dc337c80   edi: dc9218d5   ebp: dc06e600   esp: dc31de4c
Jun 18 16:49:23 canoe kernel: ds: 0018   es: 0018   ss: 0018
Jun 18 16:49:23 canoe kernel: Process ls (pid: 1151, stackpage=dc31d000)
Jun 18 16:49:23 canoe kernel: Stack: dff83800 dc06e665 c0152721 dff83800 000011bb dc921880 ffffffea
00000000 
Jun 18 16:49:23 canoe kernel:        dc62f400 c0145569 c1787100 000001f0 dc06e600 fffffff4 dc660580
dc62f400 
Jun 18 16:49:23 canoe kernel:        c013cc33 dc660580 dc06e600 dc31df64 00000000 dc660580 dc31df9c
c013d3ec 
Jun 18 16:49:23 canoe kernel: Call Trace: [proc_lookup+161/176] [d_alloc+25/368]
[real_lookup+163/208] [link_path_walk+1708/2000] [filldir64+239/352] 
Jun 18 16:49:23 canoe kernel: Call Trace: [<c0152721>] [<c0145569>] [<c013cc33>] [<c013d3ec>]
[<c014132f>] 
Jun 18 16:49:23 canoe kernel:    [do_page_fault+764/1239] [getname+109/176] [__user_walk+58/80]
[sys_lstat64+20/112] [error_code+52/60] [system_call+51/56] 
Jun 18 16:49:23 canoe kernel:    [<c011431c>] [<c013c90d>] [<c013d8ca>] [<c013a804>] [<c010705c>]
[<c0106f6b>] 
Jun 18 16:49:23 canoe kernel: 
Jun 18 16:49:23 canoe kernel: Code: ff 40 10 8b 43 24 83 48 14 18 8b 43 18 85 c0 74 06 89 86 88
------------------------------------

-- 
Luben

[-- Attachment #2: scsi_reg.tar.gz --]
[-- Type: application/x-gzip, Size: 1480 bytes --]

Re: Fwd: Patch - SCSI host numbers - please apply

[Itai Nahshon]

On Wednesday 19 June 2002 00:18 am, Luben Tuikov wrote:
> Itai,
>
>
> After applying your patch to 2.4.18, I see the following
> problems:

Well, I just tried that with 2.4.18-pre10 + my patch and I do not
see any of the problems that you described. I suspect there
is something wrong with your configuration or with the
way that you run your tests.

I first loaded ide-scsi (which got host_no 0) and then
the object that I got from compiling yout code with
MaxHosts=30 (and it got host_nos 1 .. 30).
Removng the modules worked OK too. The hosts were
unregistered and off course, no oops.
Then reloaded scsi_reg.o with MaxHosts=100. Again no
problem.

My configuration:
RedHat 7.2, non-SMP. All the updates from RedHat applied +KDE-3.0.
Relevant RPMS:
	gcc-2.96-98
	cpp-2.96-98
	binutils-2.11.90.0.8-11
	modutils-2.4.13-0.7.1

The kernel source tree is symbolic linked to /usr/src/linux .
Your code extracted to /usr/src/scsi_reg/ .


-- Itai

Re: Fwd: Patch - SCSI host numbers - please apply

[Luben Tuikov]

Itai Nahshon wrote:

> I suspect there
> is something wrong with your configuration or with the
> way that you run your tests.

What could be wrong with my configuration? Anything specific
that you have in mind?

What do you mean ``they way you run your tests''?
Could you please elaborate...

The second time you loaded the module did you get
1 to 100 or 31 to 131?
 
> My configuration:
> RedHat 7.2, non-SMP. All the updates from RedHat applied +KDE-3.0.
> Relevant RPMS:
>         gcc-2.96-98
>         cpp-2.96-98
>         binutils-2.11.90.0.8-11
>         modutils-2.4.13-0.7.1

My configuration is as follows (RH7.1):
- kernel: 2.4.18
- gcc 3.0.4 
Reading specs from /usr/local/lib/gcc-lib/i686-pc-linux-gnu/3.0.4/specs
Configured with: ../gcc-3.0.4/configure --host=i686-pc-linux-gnu --with-gnu-as --with-gnu-ld
--disable-win32-registry --enable-threads=posix
Thread model: posix
gcc version 3.0.4
- GNU ld version 2.10.91 (with BFD 2.10.91.0.2)
- modinfo (Linux modutils) 2.4.2

This is very strange, maybe we should get someone else to
independently test this? (scsi_reg.o with and without your patch
on a 2.4.18.)

Anyone?

-- 
Luben