Re: Q: aborting commands

[Luben Tuikov <luben@splentec.com>]

Mike Anderson wrote:
> 
> Luben Tuikov [luben@splentec.com] wrote:
> > I've been meaning to ask this for some time now:
> > What is the consensus on the meaning of an aborted command?
> >
> > Most notably in the SCSI LLP standards, a successfully aborted command
> > will NOT return status as non-aborted commands would (normally) do.
> >
> > 1. Should successfully aborted commands call scsi_done()?
> >    (of course with result=DID_ABORT)
>
> The new eh on calling eh_abort_handler on a cmd believes that it is the
> owner of the command again.

Yes, we know. That's why the ability to sleep on eh, else
there's no way out...
 
> I also noticed an issue in our current error handling in that if call
> eh_abort_handler we may want to call eh_device_reset_handler on the
> device later in recovery. The issue is that it at least one
> implementation by a LLDD this is a either / or case not a progressive
> step of error recovery.

I don't understand this.
 
> How could a LLDD know where the error occurred on a timeout. Take FC for
> example the problem could be a dropped response IU (with device
> completing the cmd) or a class 3 data frame dropped in the middle.

Right, in this case it cannot.

Anyway I was just throwing ideas and questions to increase the brainstorm
pool at linux-scsi, nothing more.

-- 
Luben