From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Morton Subject: Re: 2.5.43 IO-APIC bug and spinlock deadlock Date: Wed, 16 Oct 2002 21:40:24 -0700 Sender: linux-scsi-owner@vger.kernel.org Message-ID: <3DAE3F38.11C9E4F1@digeo.com> References: <20021017033302.GP8159@redhat.com> <20021017042851.GQ8159@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Return-path: List-Id: linux-scsi@vger.kernel.org To: Doug Ledford Cc: linux-kernel@vger.kernel.org, Ingo Molnar , linux-scsi@vger.kernel.org Doug Ledford wrote: > > On Wed, Oct 16, 2002 at 11:33:02PM -0400, Doug Ledford wrote: > > IO-APIC bug: regular kernel, UP, no IO-APIC or APIC on UP enabled, compile > > fails (does *everyone* run SMP or at least UP + APIC now?) > > OK, this is real. > Linus has merged a patch for this. Does it work for you? I don't think you've sent us any error output. include/asm-i386/apic.h | 4 ++-- include/asm-i386/smp.h | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) --- 2.5.43/include/asm-i386/smp.h~mpparse-fix Tue Oct 15 21:26:18 2002 +++ 2.5.43-akpm/include/asm-i386/smp.h Tue Oct 15 21:26:31 2002 @@ -37,6 +37,7 @@ #endif /* CONFIG_CLUSTERED_APIC */ #endif +#define BAD_APICID 0xFFu #ifdef CONFIG_SMP #ifndef __ASSEMBLY__ @@ -65,7 +66,6 @@ extern void zap_low_mappings (void); * the real APIC ID <-> CPU # mapping. */ #define MAX_APICID 256 -#define BAD_APICID 0xFFu extern volatile int cpu_to_physical_apicid[NR_CPUS]; extern volatile int physical_apicid_to_cpu[MAX_APICID]; extern volatile int cpu_to_logical_apicid[NR_CPUS]; --- 2.5.43/include/asm-i386/apic.h~mpparse-fix Tue Oct 15 21:34:03 2002 +++ 2.5.43-akpm/include/asm-i386/apic.h Tue Oct 15 21:34:05 2002 @@ -7,8 +7,6 @@ #include #include -#ifdef CONFIG_X86_LOCAL_APIC - #define APIC_DEBUG 0 #if APIC_DEBUG @@ -17,6 +15,8 @@ #define Dprintk(x...) #endif +#ifdef CONFIG_X86_LOCAL_APIC + /* * Basic functions accessing APICs. */ .