From: Andrew Morton <akpm@digeo.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: "Justin T. Gibbs" <gibbs@scsiguy.com>, linux-scsi@vger.kernel.org
Subject: Re: slave_destroy called in scsi_scan.c:scsi_probe_and_add_lun()
Date: Tue, 17 Dec 2002 14:54:43 -0800 [thread overview]
Message-ID: <3DFFAB33.F174D272@digeo.com> (raw)
In-Reply-To: 20021217223341.A26529@infradead.org
Christoph Hellwig wrote:
>
> On Tue, Dec 17, 2002 at 05:24:59PM -0500, Doug Ledford wrote:
> > Well, that or I need Jens to clean up the block layer allocation code so
> > that it only allocates one request at block queue init time and from then
> > on does lazy request allocations once the device needs them, similar to
> > what I did with the scsi command blocks.
>
> What do you think about forward-porting akpm's blk_grow_request_list()
> changes in 2.4? I could do that easily and it should help to get this
> sorted out properly.
>
wakes up.
I think (hope) the plan there is to do away with the preallocated
per-queue request lists altogether. Just allocate the requests
direct from slab at __make_request().
The request slab would have to be backed by a (small) mempool of
course. get_request_wait() should disappear, and management of
the amount of memory which is under IO is moved up to the VM layer.
This means that we have basically no upper bound on the amount of
memory which can be placed under I/O. Which used to give the VM
a heart-attack, but it should be OK for writes now. If not I'll
fix it up. There could be issues with reads and direct-IO.
The rbtree elevator becomes compulsory with such potentially-large
queues, but that's working fine.
next prev parent reply other threads:[~2002-12-17 22:55 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-12-16 23:19 slave_destroy called in scsi_scan.c:scsi_probe_and_add_lun() Justin T. Gibbs
2002-12-17 0:03 ` Douglas Gilbert
2002-12-17 5:41 ` Doug Ledford
2002-12-17 20:25 ` Justin T. Gibbs
2002-12-17 22:24 ` Doug Ledford
2002-12-17 22:33 ` Christoph Hellwig
2002-12-17 22:54 ` Andrew Morton [this message]
2002-12-18 1:00 ` Doug Ledford
2002-12-18 1:03 ` William Lee Irwin III
2002-12-18 1:22 ` Andrew Morton
2002-12-18 3:22 ` Luben Tuikov
2002-12-18 2:07 ` Justin T. Gibbs
2002-12-18 3:35 ` Doug Ledford
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3DFFAB33.F174D272@digeo.com \
--to=akpm@digeo.com \
--cc=gibbs@scsiguy.com \
--cc=hch@infradead.org \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox