From: Luben Tuikov <luben@splentec.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: linux-scsi@vger.kernel.org
Subject: Re: [PATCH] SCSI Core cmd->host ==> cmd->device->host 2/3
Date: Mon, 13 Jan 2003 11:46:56 -0500 [thread overview]
Message-ID: <3E22ED80.60408@splentec.com> (raw)
In-Reply-To: 20030111174529.A2225@infradead.org
Christoph Hellwig wrote:
> On Mon, Jan 06, 2003 at 07:16:56PM -0500, Luben Tuikov wrote:
>
>>This patch makes the conversion from scsi cmd->host to
>>scsi cmd->device->host for drivers/scsi/*, drivers/usb/storage/*,
>>drivers/ieee1394/*, drivers/message/fusion/* .
>
>
> The patch looks fine in principle. Two purely cosmetic nitpicks:
>
> 1) Please linewrap the now longer lines after 80 lines
> 2) the cast when assining from ->hostdata are superflous
>
> I know 2) is not your fault, but as you touch it fixing that might make
> sense, and usually fixes 1).
I wanted to minimize distuption as much as possible, for this reason
I didn't do as much of 1) or 2). I was tempted, but the principle
prevailed.
Such changes will have to be done at the next overhaul.
--
Luben
prev parent reply other threads:[~2003-01-13 16:46 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-01-07 0:16 [PATCH] SCSI Core cmd->host ==> cmd->device->host 2/3 Luben Tuikov
2003-01-11 17:45 ` Christoph Hellwig
2003-01-13 16:46 ` Luben Tuikov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3E22ED80.60408@splentec.com \
--to=luben@splentec.com \
--cc=hch@infradead.org \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox