From: Luben Tuikov <luben@splentec.com>
To: Christoph Hellwig <hch@lst.de>
Cc: Patrick Mansfield <patmans@us.ibm.com>,
James.Bottomley@steeleye.com, linux-scsi@vger.kernel.org
Subject: Re: [PATCH] fixes and cleanups for the new command allocation code
Date: Tue, 04 Feb 2003 13:08:20 -0500 [thread overview]
Message-ID: <3E400194.2000707@splentec.com> (raw)
In-Reply-To: 20030204190331.A32115@lst.de
Christoph Hellwig wrote:
>
> The trend is to have as much variables as possible static to one source
> file and if that is not possible have it global in C language scope but
> not exported to modules.
I was (of course) referring to those ``global in C language scope''.
I think that it would be cleaner to encapsulate them in a variable of
type structure, which will abide by the same rules of course. My opinion
is that this would be cleaner.
--
Luben
next prev parent reply other threads:[~2003-02-04 18:08 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-02-04 15:23 [PATCH] fixes and cleanups for the new command allocation code Christoph Hellwig
2003-02-04 16:16 ` Patrick Mansfield
2003-02-04 16:51 ` Christoph Hellwig
2003-02-04 17:19 ` Patrick Mansfield
2003-02-04 17:57 ` Luben Tuikov
2003-02-04 18:03 ` Christoph Hellwig
2003-02-04 18:08 ` Luben Tuikov [this message]
2003-02-04 18:33 ` James Bottomley
2003-02-04 19:29 ` Christoph Hellwig
2003-02-04 23:03 ` James Bottomley
2003-02-05 1:25 ` Patrick Mansfield
2003-02-05 1:53 ` James Bottomley
2003-02-05 5:15 ` Patrick Mansfield
2003-02-05 15:22 ` James Bottomley
2003-02-05 15:59 ` James Bottomley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3E400194.2000707@splentec.com \
--to=luben@splentec.com \
--cc=James.Bottomley@steeleye.com \
--cc=hch@lst.de \
--cc=linux-scsi@vger.kernel.org \
--cc=patmans@us.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox