Re: why store the search type in the ieee name field?

Steven Dake
2003-02-11T17:38:59Z

When I looked at this code originally, it looked correct, I was just
wondering why have an identifier field. I understand the reasoning now.

Thanks
-steve

James Bottomley wrote:

>On Tue, 2003-02-11 at 10:20, Patrick Mansfield wrote:
>
>
>>On Mon, Feb 10, 2003 at 05:12:54PM -0600, James Bottomley wrote:
>>
>>
>>>Erm, it's appending the type to the beginning of the name string
>>>(although it does seem to be relying on the sysfs name field being zero
>>>filled). I don't see any corruption since the inquiry fields and unique
>>>name name follows this byte.
>>>
>>>
>>It should fill in the rest of the 'name' and append a '\0', or return a
>>failure.
>>
>>
>
>No, look at the code. After doing name[0] = hex_str[...
>it then does a strcat. If name is full of junk, strcat will append
>after the first \0 it finds (which may be off the end of the name
>field). It only works because name[1] is zero but nothing seems to
>clear it. I'm hoping it's being cleared in a piece of code I haven't
>found yet...
>
>James
>
>
>
>
>
>
>