* [PATCH] scsi_ioctl.c for SEND_DIAGNOSTIC
@ 2003-03-26 10:02 Douglas Gilbert
0 siblings, 0 replies; only message in thread
From: Douglas Gilbert @ 2003-03-26 10:02 UTC (permalink / raw)
To: linux-scsi
[-- Attachment #1: Type: text/plain, Size: 405 bytes --]
While doing foreground extended self tests with
smartmontools I found that the timeout was much to
short for SCSI_IOCTL_SEND_COMMAND. On my 18 GB
disk that test takes about 12 minutes.
Attachment extends timeout to the same as FORMAT
(i.e. 2 hours). The patch is against lk 2.5.66 .
BTW Foreground extended self tests (and FORMATs :-))
should not be done on disks with mounted partitions.
Doug Gilbert
[-- Attachment #2: scsi_ioctl_2566.diff --]
[-- Type: text/plain, Size: 302 bytes --]
--- linux/drivers/scsi/scsi_ioctl.c 2003-03-05 21:01:15.000000000 +1000
+++ linux/drivers/scsi/scsi_ioctl.c2566dpg 2003-03-26 19:47:18.000000000 +1000
@@ -298,6 +298,7 @@
goto error;
switch (opcode) {
+ case SEND_DIAGNOSTIC:
case FORMAT_UNIT:
timeout = FORMAT_UNIT_TIMEOUT;
retries = 1;
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2003-03-26 10:03 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2003-03-26 10:02 [PATCH] scsi_ioctl.c for SEND_DIAGNOSTIC Douglas Gilbert
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox