From: Douglas Gilbert <dougg@torque.net>
To: marcelo@hera.kernel.org
Cc: alan@lxorguk.ukuu.org.uk, linux-scsi@vger.kernel.org
Subject: [PATCH] scsi SEND DIAGNOSTIC timeout 2.4.21-pre6
Date: Fri, 04 Apr 2003 22:31:13 +1000 [thread overview]
Message-ID: <3E8D7B11.1070708@torque.net> (raw)
[-- Attachment #1: Type: text/plain, Size: 483 bytes --]
Marcelo,
While working with smartmontools I found that an
extended foreground self-test failed because the
SCSI command that sends it: SEND DIAGNOSTIC, has a
normal timeout value of 10 seconds. With my 18 GB
disk this test takes 12 minutes. Larger disks can
take up to an hour.
This patch makes the SCSI_IOCTL_SEND_COMMAND ioctl's
timeout for SEND DIAGNOSTIC the same as it is for
FORMAT (2 hours).
The scsi_ioctl.c file is the same in lk 2.4.20 and
lk 2.4.21-pre6 .
Doug Gilbert
[-- Attachment #2: scsi_ioctl_2420sd.diff --]
[-- Type: text/plain, Size: 333 bytes --]
--- linux/drivers/scsi/scsi_ioctl.c 2002-08-09 01:31:46.000000000 +1000
+++ linux/drivers/scsi/scsi_ioctl.c2420sd 2003-04-04 21:58:44.000000000 +1000
@@ -282,6 +282,7 @@
cmd[1] = (cmd[1] & 0x1f) | (dev->lun << 5);
switch (opcode) {
+ case SEND_DIAGNOSTIC:
case FORMAT_UNIT:
timeout = FORMAT_UNIT_TIMEOUT;
retries = 1;
reply other threads:[~2003-04-04 12:19 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3E8D7B11.1070708@torque.net \
--to=dougg@torque.net \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=linux-scsi@vger.kernel.org \
--cc=marcelo@hera.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox