public inbox for linux-scsi@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH] scsi SEND DIAGNOSTIC timeout 2.4.21-pre6
@ 2003-04-04 12:31 Douglas Gilbert
  0 siblings, 0 replies; only message in thread
From: Douglas Gilbert @ 2003-04-04 12:31 UTC (permalink / raw)
  To: marcelo; +Cc: alan, linux-scsi

[-- Attachment #1: Type: text/plain, Size: 483 bytes --]

Marcelo,
While working with smartmontools I found that an
extended foreground self-test failed because the
SCSI command that sends it: SEND DIAGNOSTIC, has a
normal timeout value of 10 seconds. With my 18 GB
disk this test takes 12 minutes. Larger disks can
take up to an hour.

This patch makes the SCSI_IOCTL_SEND_COMMAND ioctl's
timeout for SEND DIAGNOSTIC the same as it is for
FORMAT (2 hours).

The scsi_ioctl.c file is the same in lk 2.4.20 and
lk 2.4.21-pre6 .

Doug Gilbert

[-- Attachment #2: scsi_ioctl_2420sd.diff --]
[-- Type: text/plain, Size: 333 bytes --]

--- linux/drivers/scsi/scsi_ioctl.c	2002-08-09 01:31:46.000000000 +1000
+++ linux/drivers/scsi/scsi_ioctl.c2420sd	2003-04-04 21:58:44.000000000 +1000
@@ -282,6 +282,7 @@
 		cmd[1] = (cmd[1] & 0x1f) | (dev->lun << 5);
 
 	switch (opcode) {
+	case SEND_DIAGNOSTIC:
 	case FORMAT_UNIT:
 		timeout = FORMAT_UNIT_TIMEOUT;
 		retries = 1;

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2003-04-04 12:19 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2003-04-04 12:31 [PATCH] scsi SEND DIAGNOSTIC timeout 2.4.21-pre6 Douglas Gilbert

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox