Re: [PATCH] instrument ide-scsi in 2.5.68

[Douglas Gilbert <dougg@torque.net>]

[-- Attachment #1: Type: text/plain, Size: 1059 bytes --]

Douglas Gilbert wrote:
> <snip/>
>   - instrument driver with 2 parameters (as examples)
>       - ide-scsi.debug + ide-scsi.suppress_reset
>         [kernel load time]
>       - debug + suppress_reset [module load time]
>       - debug + suppress_reset [sysfs: read/write
>         in /sys/bus/ide/drivers/ide-scsi directory]
>   - downgrade (simple) tag queuing to no tag queuing
>     [set some other things to more conservative values]
>   - add scsi_host::release() method
>   - make provision for 16 byte SCSI commands
>   - cleanup printk()s
 > <snip/>

As Randy has found the setting of kernel boot time parameters
doesn't work. The problem seems to be that the ide subsystem
asserts ownership over all parameters that start with "ide".
I was unable to bend moduleparam.h to accept a leading underscore
so I went back to the old "__setup" method: the kernel boot time
parameters are now:
   - _ide_scsi_debug + _ide_scsi_suppress_reset

Module load time and sysfs parameters remain the same.

A new patch against lk 2.5.68 is attached.

Doug Gilbert


[-- Attachment #2: ide-scsi_2568_2.diff.gz --]
[-- Type: application/x-gzip, Size: 7485 bytes --]