Re: [RFC] scsi host sysfs support again [0/4]

[Douglas Gilbert <dougg@torque.net>]

Mike Anderson wrote:
> Douglas Gilbert [dougg@torque.net] wrote:
> 
>>What seems to be missing, at least in what I am
>>running here is a useful 'name'. There is no 'name'
>>file in the listing above (under each 'host<n>'
>>directory). There is a 'name' file in that 'device' (symlink)
>>directory but it is an empty file here.
>>
>>
>>># tree /sys/bus/scsi/devices
>>>/sys/bus/scsi/devices
>>>|-- 0:0:0:0 -> ../../../devices/pci0/00:09.0/host0/0:0:0:0
>>
>>So finally I can get some output from my
>>version of lsscsi (unreleased version 10):
>>
>>$ lsscsi -Hl
>>[0]    ??
>>  cmd_per_lun=64   host_busy=0    sg_tablesize=96   unchecked_isa_dma=0
>>[1]    ??
>>  cmd_per_lun=64   host_busy=0    sg_tablesize=96   unchecked_isa_dma=0
>>[2]    ??
>>  cmd_per_lun=3    host_busy=0    sg_tablesize=64   unchecked_isa_dma=0
>>[3]    ??
>>  cmd_per_lun=5    host_busy=0    sg_tablesize=255  unchecked_isa_dma=0
>>
>>Hosts 0 and 1 are the 2 HBAs on a Tekram 390u3w while
>>host 2 is a scsi_debug pseudo host and host3 is
>>ide-scsi. A name would be instructive.
>>
>>$ lsscsi
>>[0:0:1:0]    disk    FUJITSU  MAM3184MP        0106  /dev/sda
>>[2:0:0:0]    disk    Linux    scsi_debug       0004  /dev/sdb
>>[3:0:0:0]    cd      CREATIVE CD5233E          1.00  /dev/sr0
>>
> 
> 
> OK, that is a bug. Is proc_name ok for name
> 
> # cat /sys/class/scsi_host/*/device/name
> ips
> aic7xxx
> aic7xxx

Mike,
Yes, proc_name is fine (although the previous release
of this patch set used a longer winded variant).

Also the 'unique_id' attribute looks a bit strange
(or is aften misued by LLDs).
$ cat /sys/class/scsi_host/host[0123]/unique_id
33792        # half 390u3w
32768        # other half 390u3w
0            # ide-scsi
0            # Adaptec AIC-7892A

This is nothing to do with your patch, of course. Does
the unique_id help the user space in any way?

Doug Gilbert