From: Douglas Gilbert <dougg@torque.net>
To: linux-scsi@vger.kernel.org
Subject: [PATCH] scsi_status() macro
Date: Fri, 16 May 2003 09:50:45 +1000 [thread overview]
Message-ID: <3EC427D5.3060309@torque.net> (raw)
[-- Attachment #1: Type: text/plain, Size: 118 bytes --]
Here is a replacement macro for status_byte().
Leave the status_byte() macro and mark it as deprecated.
Doug Gilbert
[-- Attachment #2: scsi_h2569bk8cc.diff --]
[-- Type: text/plain, Size: 1105 bytes --]
--- linux/drivers/scsi/scsi.h 2003-05-14 18:09:21.000000000 +1000
+++ linux/drivers/scsi/scsi.h2569bk8cc 2003-05-16 09:47:11.469708960 +1000
@@ -90,12 +90,19 @@
*
* These are set by:
*
- * status byte = set from target device
+ * status byte = set from target device (SCSI status value)
* msg_byte = return status from host adapter itself.
* host_byte = set by low-level driver to indicate status.
* driver_byte = set by mid-level.
+ *
+ * Notes about following macros:
+ * scsi_status() returns a standard SCSI status value that may
+ * be compared with the SAM_STAT_... series of defines.
+ * status_byte() returns a shifted SCSI status value that matches
+ * CHECK_CONDITION and friends. status_byte() is deprecated.
*/
-#define status_byte(result) (((result) >> 1) & 0x1f)
+#define scsi_status(result) ((result) & 0x7e)
+#define status_byte(result) (((result) >> 1) & 0x1f) /* deprecated */
#define msg_byte(result) (((result) >> 8) & 0xff)
#define host_byte(result) (((result) >> 16) & 0xff)
#define driver_byte(result) (((result) >> 24) & 0xff)
next reply other threads:[~2003-05-15 23:37 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-05-15 23:50 Douglas Gilbert [this message]
2003-05-16 1:11 ` [PATCH] scsi_status() macro James Bottomley
2003-05-16 5:32 ` Douglas Gilbert
-- strict thread matches above, loose matches on Subject: below --
2003-05-16 12:12 Andries.Brouwer
2003-05-17 4:38 ` Douglas Gilbert
2003-05-17 4:59 Andries.Brouwer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3EC427D5.3060309@torque.net \
--to=dougg@torque.net \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox