* RFC: move hosts.h, scsi.h
@ 2003-05-22 20:34 Jeff Garzik
2003-05-22 20:45 ` Christoph Hellwig
2003-05-22 21:04 ` Andries Brouwer
0 siblings, 2 replies; 6+ messages in thread
From: Jeff Garzik @ 2003-05-22 20:34 UTC (permalink / raw)
To: SCSI Mailing List
I request permission to do the following:
1) bk mv drivers/scsi/scsi.h include/linux
2) bk mv drivers/scsi/hosts.h include/linux/scsi_hosts.h
3) bk mv drivers/scsi/scsi_obsolete.h include/linux
4) create shell drivers/scsi/{...}.h that includes just-moved files, so
to preserve full driver source compatibility.
5) edit include/linux/scsi.h to include <linux/scsi_obsolete.h> not
"scsi_obsolete.h"
Objections/comments?
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: RFC: move hosts.h, scsi.h
2003-05-22 20:34 RFC: move hosts.h, scsi.h Jeff Garzik
@ 2003-05-22 20:45 ` Christoph Hellwig
2003-05-22 21:59 ` Andries Brouwer
2003-05-23 1:52 ` Jeff Garzik
2003-05-22 21:04 ` Andries Brouwer
1 sibling, 2 replies; 6+ messages in thread
From: Christoph Hellwig @ 2003-05-22 20:45 UTC (permalink / raw)
To: Jeff Garzik; +Cc: SCSI Mailing List
On Thu, May 22, 2003 at 04:34:53PM -0400, Jeff Garzik wrote:
> I request permission to do the following:
>
> 1) bk mv drivers/scsi/scsi.h include/linux
> 2) bk mv drivers/scsi/hosts.h include/linux/scsi_hosts.h
> 3) bk mv drivers/scsi/scsi_obsolete.h include/linux
> 4) create shell drivers/scsi/{...}.h that includes just-moved files, so
> to preserve full driver source compatibility.
> 5) edit include/linux/scsi.h to include <linux/scsi_obsolete.h> not
> "scsi_obsolete.h"
>
> Objections/comments?
It's not that easy. The current host.h/scsi.h split is silly we either want
to merge them or better split them saner (and into more pieces). The current
scsi_obsolete.h should go away completly, it may make a driver compile but
not work (missing EH). OTOH all those ugly typedefs should move into a 'new'
onbsolete.h. Also all this should go into include/scsi/
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: RFC: move hosts.h, scsi.h
2003-05-22 20:34 RFC: move hosts.h, scsi.h Jeff Garzik
2003-05-22 20:45 ` Christoph Hellwig
@ 2003-05-22 21:04 ` Andries Brouwer
2003-05-23 1:54 ` Jeff Garzik
1 sibling, 1 reply; 6+ messages in thread
From: Andries Brouwer @ 2003-05-22 21:04 UTC (permalink / raw)
To: Jeff Garzik; +Cc: SCSI Mailing List
On Thu, May 22, 2003 at 04:34:53PM -0400, Jeff Garzik wrote:
> I request permission to do the following:
>
> 1) bk mv drivers/scsi/scsi.h include/linux
> 2) bk mv drivers/scsi/hosts.h include/linux/scsi_hosts.h
> 3) bk mv drivers/scsi/scsi_obsolete.h include/linux
> 4) create shell drivers/scsi/{...}.h that includes just-moved files, so
> to preserve full driver source compatibility.
> 5) edit include/linux/scsi.h to include <linux/scsi_obsolete.h> not
> "scsi_obsolete.h"
>
> Objections/comments?
No doubt with the goal of removing all those ugly
#include "../../scsi/hosts.h"
A good plan.
I think point 5) is superfluous.
(That is, I think by default "foo.h" is found in the directory
of the including file.)
Probably this would mean that usb/storage/Makefile no longer
needs -Idrivers/scsi, provided the "scsi.h" there is replaced
by <linux/scsi.h>.
Remains the vague objection: it is a bit confusing to have
several files of the same name. And in case some compilation
has both include/linux and include/scsi on the include path
there are ordering restraints. Maybe life will be easier
if you invent some other name like scsidefs.h.
Andries
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: RFC: move hosts.h, scsi.h
2003-05-22 20:45 ` Christoph Hellwig
@ 2003-05-22 21:59 ` Andries Brouwer
2003-05-23 1:52 ` Jeff Garzik
1 sibling, 0 replies; 6+ messages in thread
From: Andries Brouwer @ 2003-05-22 21:59 UTC (permalink / raw)
To: Christoph Hellwig; +Cc: Jeff Garzik, SCSI Mailing List
On Thu, May 22, 2003 at 09:45:56PM +0100, Christoph Hellwig wrote:
> Also all this should go into include/scsi/
Long ago include/scsi was created to contain stuff for
inclusion by user space.
But yes, I see that several of these files have been
polluted already with kernel-only stuff.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: RFC: move hosts.h, scsi.h
2003-05-22 20:45 ` Christoph Hellwig
2003-05-22 21:59 ` Andries Brouwer
@ 2003-05-23 1:52 ` Jeff Garzik
1 sibling, 0 replies; 6+ messages in thread
From: Jeff Garzik @ 2003-05-23 1:52 UTC (permalink / raw)
To: Christoph Hellwig; +Cc: SCSI Mailing List
Christoph Hellwig wrote:
> On Thu, May 22, 2003 at 04:34:53PM -0400, Jeff Garzik wrote:
>
>>I request permission to do the following:
>>
>>1) bk mv drivers/scsi/scsi.h include/linux
>>2) bk mv drivers/scsi/hosts.h include/linux/scsi_hosts.h
>>3) bk mv drivers/scsi/scsi_obsolete.h include/linux
>>4) create shell drivers/scsi/{...}.h that includes just-moved files, so
>>to preserve full driver source compatibility.
>>5) edit include/linux/scsi.h to include <linux/scsi_obsolete.h> not
>>"scsi_obsolete.h"
>>
>>Objections/comments?
>
>
> It's not that easy. The current host.h/scsi.h split is silly we either want
> to merge them or better split them saner (and into more pieces). The current
> scsi_obsolete.h should go away completly, it may make a driver compile but
> not work (missing EH). OTOH all those ugly typedefs should move into a 'new'
> onbsolete.h. Also all this should go into include/scsi/
This is a whole list of steps to perform after I submit the above changes :)
Sure there are many other improvements to be made. What I suggest is
one small step in that direction. It's an important step because it's
the minimum necessary to get a sane include structure, with minimum
controversy. It's also backport-able to 2.4.
Since files are now just a "bk mv" away from a new pathname, a new file
location may easily be debated and then implemented, at a later date.
Jeff
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: RFC: move hosts.h, scsi.h
2003-05-22 21:04 ` Andries Brouwer
@ 2003-05-23 1:54 ` Jeff Garzik
0 siblings, 0 replies; 6+ messages in thread
From: Jeff Garzik @ 2003-05-23 1:54 UTC (permalink / raw)
To: Andries Brouwer; +Cc: SCSI Mailing List
Andries Brouwer wrote:
> On Thu, May 22, 2003 at 04:34:53PM -0400, Jeff Garzik wrote:
>
>
>>I request permission to do the following:
>>
>>1) bk mv drivers/scsi/scsi.h include/linux
>>2) bk mv drivers/scsi/hosts.h include/linux/scsi_hosts.h
>>3) bk mv drivers/scsi/scsi_obsolete.h include/linux
>>4) create shell drivers/scsi/{...}.h that includes just-moved files, so
>>to preserve full driver source compatibility.
>>5) edit include/linux/scsi.h to include <linux/scsi_obsolete.h> not
>>"scsi_obsolete.h"
>>
>>Objections/comments?
>
>
> No doubt with the goal of removing all those ugly
> #include "../../scsi/hosts.h"
Yes, and nasty -I hacks in Makefiles.
> A good plan.
>
> I think point 5) is superfluous.
> (That is, I think by default "foo.h" is found in the directory
> of the including file.)
I thought so too, but gcc disagreed :)
I think '#include <linux/...>' is more clean, too.
> Probably this would mean that usb/storage/Makefile no longer
> needs -Idrivers/scsi, provided the "scsi.h" there is replaced
> by <linux/scsi.h>.
Yep
> Remains the vague objection: it is a bit confusing to have
> several files of the same name. And in case some compilation
> has both include/linux and include/scsi on the include path
> there are ordering restraints. Maybe life will be easier
> if you invent some other name like scsidefs.h.
Easily done and a good objection/suggestion. I'm using
scsi_{defs,hosts,obsolete}.h in my local tree right now.
Jeff
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2003-05-23 1:41 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2003-05-22 20:34 RFC: move hosts.h, scsi.h Jeff Garzik
2003-05-22 20:45 ` Christoph Hellwig
2003-05-22 21:59 ` Andries Brouwer
2003-05-23 1:52 ` Jeff Garzik
2003-05-22 21:04 ` Andries Brouwer
2003-05-23 1:54 ` Jeff Garzik
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox