[Patch]Status_byte() in drivers/scsi/scsi.h

[Sachin Sant <sachinp@in.ibm.com>]

According to Dougs comments , here is the patch to include new macros
for SAM status codes . Patch is in drivers/scsi/scsi.h

--- scsi.h	2003-06-19 14:26:54.000000000 +0530
+++ scsi.h.new	2003-06-20 13:54:46.000000000 +0530
@@ -95,6 +95,13 @@
  *      host_byte   = set by low-level driver to indicate status.
  *      driver_byte = set by mid-level.
  */
+
+/* 
+ * Define a new macro sam_status_value for the status codes
+ * defined for new SCSI Architecture Model SAM 
+ */
+#define sam_status_value(scmd_result) ((scmd_result) & 0x7e)
+
 #define status_byte(result) (((result) >> 1) & 0x1f)
 #define msg_byte(result)    (((result) >> 8) & 0xff)

Any comments are welcome.

Thanks
-Sachin 
-----------------------------------------------------------------------------------

Douglas Gilbert wrote:
> Sachin,
> The status_byte() macro is for SCSI-2 and earlier and
> matches a Linux-specific set of defines that are
> shifted from the "standard" values (e.g. CHECK_CONDITION).
> In those days bit 6 was not in use.
> 
> We are still arguing about the exact form of the macro
> to use that matches the SAM_STAT_ defines show above.
> In the meantime you could use:
>    #define sam_status_value(scmd_result) ((scmd_result) & 0x7e)
> and compare the result with the SAM_STAT_ defines above.
> 
> Doug Gilbert
> 
> -
> To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html