PATCH: scsi_debug bug

PATCH: scsi_debug bug

[Jeff Garzik]

[-- Attachment #1: Type: text/plain, Size: 261 bytes --]

No response the first time.  Resending.

Can someone look at this patch and approve it, please?

It looks like an obvious bug and fix to me:  MODE_SENSE_10 allocation 
length LSB is in cdb byte 8, not byte 6.

This bug is present in both 2.4 and 2.5.

	Jeff




[-- Attachment #2: patch --]
[-- Type: text/plain, Size: 560 bytes --]

===== drivers/scsi/scsi_debug.c 1.39 vs edited =====
--- 1.39/drivers/scsi/scsi_debug.c	Mon Jun  2 20:42:21 2003
+++ edited/drivers/scsi/scsi_debug.c	Sun Jun 29 15:06:03 2003
@@ -687,7 +687,7 @@
 	pcontrol = (cmd[2] & 0xc0) >> 6;
 	pcode = cmd[2] & 0x3f;
 	msense_6 = (MODE_SENSE == cmd[0]);
-	alloc_len = msense_6 ? cmd[4] : ((cmd[7] << 8) | cmd[6]);
+	alloc_len = msense_6 ? cmd[4] : ((cmd[7] << 8) | cmd[8]);
 	/* printk(KERN_INFO "msense: dbd=%d pcontrol=%d pcode=%d "
 		"msense_6=%d alloc_len=%d\n", dbd, pcontrol, pcode, "
 		"msense_6, alloc_len); */

Re: PATCH: scsi_debug bug

[dougg]

Quoting Jeff Garzik <jgarzik@pobox.com>:

> No response the first time.  Resending.
> 
> Can someone look at this patch and approve it, please?
> 
> It looks like an obvious bug and fix to me:  MODE_SENSE_10 allocation 
> length LSB is in cdb byte 8, not byte 6.
> 
> This bug is present in both 2.4 and 2.5.

Jeff,
Guilty as charged.

Sorry for the long delay in responding. Hopefully James
and/or Mike Anderson can put the patch in the bk scsi 
repository for the lk 2.5 series.

For the lk 2.4 series, please send a patch to Marcelo 
and cc Alan.

Doug Gilbert
 




-------------------------------------------------
This mail sent through IMP: http://horde.org/imp/

Re: PATCH: scsi_debug bug

[Alan Cox]

On Maw, 2003-07-08 at 19:00, dougg@torque.net wrote:
> Guilty as charged.
> 
> Sorry for the long delay in responding. Hopefully James
> and/or Mike Anderson can put the patch in the bk scsi 
> repository for the lk 2.5 series.
> 
> For the lk 2.4 series, please send a patch to Marcelo 
> and cc Alan.

Already merged

PATCH: scsi_debug bug

[Jeff Garzik]

This is for 2.5, but should go back to 2.4 I suppose.

MODE_SENSE_10 alloc_len LSB is in cdb byte 8, not byte 6, AFAIK...

	Jeff




===== drivers/scsi/scsi_debug.c 1.39 vs edited =====
--- 1.39/drivers/scsi/scsi_debug.c	Mon Jun  2 20:42:21 2003
+++ edited/drivers/scsi/scsi_debug.c	Sun Jun 29 15:06:03 2003
@@ -687,7 +687,7 @@
 	pcontrol = (cmd[2] & 0xc0) >> 6;
 	pcode = cmd[2] & 0x3f;
 	msense_6 = (MODE_SENSE == cmd[0]);
-	alloc_len = msense_6 ? cmd[4] : ((cmd[7] << 8) | cmd[6]);
+	alloc_len = msense_6 ? cmd[4] : ((cmd[7] << 8) | cmd[8]);
 	/* printk(KERN_INFO "msense: dbd=%d pcontrol=%d pcode=%d "
 		"msense_6=%d alloc_len=%d\n", dbd, pcontrol, pcode, "
 		"msense_6, alloc_len); */