From mboxrd@z Thu Jan 1 00:00:00 1970 From: Nick Piggin Subject: Re: [PATCH] as i/o hang with aacraid driver 2.6.0-test1 Date: Thu, 17 Jul 2003 19:56:41 +1000 Sender: linux-scsi-owner@vger.kernel.org Message-ID: <3F1672D9.7070309@cyberone.com.au> References: <1058310172.981.7.camel@markh1.pdx.osdl.net> <1058359278.1856.8.camel@mulgrave> <20030716124549.GX833@suse.de> <1058360162.1850.15.camel@mulgrave> <20030716132036.GB833@suse.de> <1058364455.1856.28.camel@mulgrave> <20030716170456.GK833@suse.de> <20030717015756.135a3f5a.akpm@osdl.org> <20030717085952.GX833@suse.de> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit Return-path: Received: from dyn-ctb-210-9-246-41.webone.com.au ([210.9.246.41]:15633 "EHLO chimp.local.net") by vger.kernel.org with ESMTP id S271357AbTGQJmN (ORCPT ); Thu, 17 Jul 2003 05:42:13 -0400 In-Reply-To: <20030717085952.GX833@suse.de> List-Id: linux-scsi@vger.kernel.org To: Jens Axboe Cc: Andrew Morton , James.Bottomley@steeleye.com, markh@osdl.org, cliffw@osdl.org, linux-scsi@vger.kernel.org Jens Axboe wrote: >On Thu, Jul 17 2003, Andrew Morton wrote: > >>So this is what I ended up with. Could we please have confirmation that it >>fixes the aacraid hang? >> > >It doesn't, it's just a pre-requisite to fixing the bug :-) > >Nick should chime in with how we wants it to be handled from >blk_requeue_request(), he needs to decrease dispatched from there. We >could always add some hook for it of course, but... > Well you could just put an elv_completed_request in there, but I suppose it really wants an elv_requeue_request - which would just default to elv_add_request for other schedulers.