From: Manfred Spraul <manfred@colorfullife.com>
To: Andrew Vasquez <andrew.vasquez@qlogic.com>
Cc: linux-scsi@vger.kernel.org,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Christoph Hellwig <hch@lst.de>,
Arjan van de Ven <arjanv@redhat.com>
Subject: Re: [ANNOUNCE] QLogic qla2xxx driver update available (v8.00.00b4).
Date: Sat, 19 Jul 2003 03:05:25 +0200 [thread overview]
Message-ID: <3F189955.6040308@colorfullife.com> (raw)
Andrew wrote:
>> - qla2x00_intr_handler should use spin_lock, not spin_lock_irqsave
>
>Are you sure about that? I'll need to refresh my interrupt handling
>know-how...
>
>
It's an optimization that is used by many drivers:
Interrupt handlers are never reentered - if you are within
qla2x00_intr_handler handling irq x, then it's guaranteed that the
function won't be reentered by another occurance of the same interrupt.
If your driver registers only one interrupt handler, then you can skip
disabling the local interrupts - a deadlock is not possible.
You need _irqsave if the spinlock is shared between multiple instances
of the hba, with different interrupts (i.e. it's possible that
qla2x00_intr_handler is called for irq y while handling irq x).
--
Manfred
next reply other threads:[~2003-07-19 0:57 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-07-19 1:05 Manfred Spraul [this message]
-- strict thread matches above, loose matches on Subject: below --
2005-01-14 20:24 [ANNOUNCE] QLogic qla2xxx driver update available (v8.00.00b4) Eric Pesciotta
2003-07-18 21:53 Andrew Vasquez
2003-07-18 21:46 Andrew Vasquez
2003-07-18 21:15 Andrew Vasquez
2003-07-17 23:40 Andrew Vasquez
2003-07-18 10:48 ` Christoph Hellwig
2003-07-18 11:23 ` Christoph Hellwig
2003-07-18 12:12 ` Lars Marowsky-Bree
2003-07-18 12:13 ` Christoph Hellwig
2003-07-18 12:26 ` Lars Marowsky-Bree
2003-07-18 12:34 ` Christoph Hellwig
2003-07-18 12:41 ` Lars Marowsky-Bree
2003-07-18 12:46 ` Christoph Hellwig
2003-07-18 13:46 ` Arjan van de Ven
2003-07-18 14:03 ` [ANNOUNCE] QLogic qla2xxx driver update available (v8.00.00b4 ) Jamie Wellnitz
2003-07-18 19:12 ` [ANNOUNCE] QLogic qla2xxx driver update available (v8.00.00b4) Christoph Hellwig
2003-07-18 19:10 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3F189955.6040308@colorfullife.com \
--to=manfred@colorfullife.com \
--cc=andrew.vasquez@qlogic.com \
--cc=arjanv@redhat.com \
--cc=hch@lst.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox