public inbox for linux-scsi@vger.kernel.org
 help / color / mirror / Atom feed
From: Brian King <brking@us.ibm.com>
To: linux-scsi@vger.kernel.org
Cc: Matthew Wilcox <willy@debian.org>,
	James Bottomley <James.Bottomley@steeleye.com>
Subject: [PATCH] sym53c8xx_2 pci_remove cleanup
Date: Wed, 08 Oct 2003 16:17:31 -0500	[thread overview]
Message-ID: <3F847EEB.4060306@us.ibm.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 189 bytes --]


This is a patch to the sym2 driver to properly cleanup midlayer 
resources both on module unload and pci hot remove.

Brian

-- 
Brian King
eServer Storage I/O
IBM Linux Technology Center

[-- Attachment #2: sym_glue-free_resources.patch --]
[-- Type: text/plain, Size: 634 bytes --]

--- linux-2.6.0-test6/drivers/scsi/sym53c8xx_2/sym_glue.c	Sat Sep 27 19:51:29 2003
+++ linux-2.6.0-test6-sym/drivers/scsi/sym53c8xx_2/sym_glue.c	Tue Oct  7 12:33:42 2003
@@ -1605,6 +1605,8 @@
 	sym_hcb_free(np);
 
 	sym_mfree_dma(np, sizeof(*np), "HCB");
+
+	scsi_host_put(np->s.host);
 }
 
 /*
@@ -1861,7 +1863,8 @@
 	printf_info("%s: giving up ...\n", sym_name(np));
 	if (np)
 		sym_free_resources(np);
-	scsi_host_put(instance);
+	else
+		scsi_host_put(instance);
 
 	return -1;
  }
@@ -2213,6 +2216,8 @@
 {
 	printk("%s: detaching ...\n", sym_name(np));
 
+	scsi_remove_host(np->s.host);
+
 	del_timer_sync(&np->s.timer);
 
 	/*

             reply	other threads:[~2003-10-08 21:17 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-10-08 21:17 Brian King [this message]
2003-10-10 11:36 ` [PATCH] sym53c8xx_2 pci_remove cleanup Matthew Wilcox
2003-10-10 18:05   ` Brian King

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3F847EEB.4060306@us.ibm.com \
    --to=brking@us.ibm.com \
    --cc=James.Bottomley@steeleye.com \
    --cc=linux-scsi@vger.kernel.org \
    --cc=willy@debian.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox