From: Douglas Gilbert <dougg@torque.net>
To: Brian King <brking@us.ibm.com>
Cc: dgilbert@interlog.com, linux-scsi@vger.kernel.org
Subject: Re: [PATCH] sg block layer tcqing fix
Date: Tue, 06 Jan 2004 15:06:51 +1000 [thread overview]
Message-ID: <3FFA426B.2030406@torque.net> (raw)
In-Reply-To: <3FF08EAF.9080708@us.ibm.com>
Brian King wrote:
> In bringing up a new LLD driver I am working on, I came across an oops
> related to sg and using the TCQ function provided by the block layer.
> The backtrace is shown below. I did some poking around and it looks like
> when doing SG_IO ioctls to devices running blk tagged command queuing,
> blk_queue_start_tag gets called, but blk_queue_end_tag never does.
> Attached is a patch against 2.6.0 which adds the call in sg_cmd_done and
> gets rid of the oops for me. Please apply.
Brian,
Thanks for this patch. As far as I can tell this patch is needed
for all SCSI char ULDs (in other words: sg, st and osst) when
used with a LLD that uses block layer queueing infrastructure.
At the moment that is only the 53c700 driver (maintained by James B.)
and that one you are working on (I suspect).
Given that no other ULDs call blk_queue_*_tag() routines it seems
a bit strange that sg, st and osst need to call blk_queue_end_tag()
prior to calling scsi_release_request(). Perhaps the cleanup can be
built into scsi_release_request() or a new variant (e.g.
scsi_release_special_request() ) could be introduced.
Doug Gilbert
next prev parent reply other threads:[~2004-01-06 5:11 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-12-29 20:29 [PATCH] sg block layer tcqing fix Brian King
2004-01-06 5:06 ` Douglas Gilbert [this message]
2004-01-06 11:46 ` Willem Riede
2004-01-06 15:14 ` James Bottomley
2004-01-06 15:22 ` Jens Axboe
2004-01-06 15:30 ` James Bottomley
2004-01-06 15:37 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3FFA426B.2030406@torque.net \
--to=dougg@torque.net \
--cc=brking@us.ibm.com \
--cc=dgilbert@interlog.com \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).