From: "Rolf Eike Beer" <eike-kernel@sf-tec.de>
To: Mike Christie <michaelc@cs.wisc.edu>
Cc: Jayamohan Kallickal <jayamohan.kallickal@emulex.com>,
james.bottomley@parallels.com, linux-scsi@vger.kernel.org
Subject: Re: [PATCH 2/3] be2iscsi: Adding a shutdown Routine
Date: Wed, 24 Aug 2011 10:53:42 +0200 [thread overview]
Message-ID: <3b1ab408eae794e1ae3a8f9331cd5249.squirrel@webmail.sf-mail.de> (raw)
In-Reply-To: <4E541995.5070408@cs.wisc.edu>
> On 08/22/2011 12:08 PM, Jayamohan Kallickal wrote:
>> +static void beiscsi_remove(struct pci_dev *pcidev)
>> +{
>> +
>> + struct beiscsi_hba *phba = NULL;
>> +
>> + phba = pci_get_drvdata(pcidev);
>
>
>> +static void beiscsi_shutdown(struct pci_dev *pcidev)
>> +{
>> +
>> + struct beiscsi_hba *phba = NULL;
>> +
>> + phba = (struct beiscsi_hba *)pci_get_drvdata(pcidev);
>
>
> No need for casting.
And no need to initialize to NULL either. Best would be
struct beiscsi_hba *phba = pci_get_drvdata(pcidev);
in both cases.
Eike
next prev parent reply other threads:[~2011-08-24 8:53 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1314032910-2304-1-git-send-email-jayamohan.kallickal@emulex.com>
2011-08-22 17:08 ` [PATCH 2/3] be2iscsi: Adding a shutdown Routine Jayamohan Kallickal
2011-08-23 21:20 ` Mike Christie
2011-08-24 8:53 ` Rolf Eike Beer [this message]
2011-08-22 17:08 ` [PATCH 3/3] be2iscsi: Add pci_disable device Jayamohan Kallickal
2011-08-22 17:08 ` be2iscsi: Patches for inclusion Jayamohan Kallickal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3b1ab408eae794e1ae3a8f9331cd5249.squirrel@webmail.sf-mail.de \
--to=eike-kernel@sf-tec.de \
--cc=james.bottomley@parallels.com \
--cc=jayamohan.kallickal@emulex.com \
--cc=linux-scsi@vger.kernel.org \
--cc=michaelc@cs.wisc.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox