From: John Garry <john.g.garry@oracle.com>
To: Niklas Cassel <cassel@kernel.org>,
Damien Le Moal <dlemoal@kernel.org>,
Jason Yan <yanaijie@huawei.com>,
"James E.J. Bottomley" <James.Bottomley@HansenPartnership.com>,
"Martin K. Petersen" <martin.petersen@oracle.com>
Cc: linux-scsi@vger.kernel.org, Hannes Reinecke <hare@suse.de>,
linux-ide@vger.kernel.org
Subject: Re: [PATCH v4 8/9] ata,scsi: Remove wrapper ata_sas_port_alloc()
Date: Thu, 4 Jul 2024 08:04:33 +0100 [thread overview]
Message-ID: <3b22bcaf-064e-48a3-b81f-209d1d8ea518@oracle.com> (raw)
In-Reply-To: <20240703184418.723066-19-cassel@kernel.org>
On 03/07/2024 19:44, Niklas Cassel wrote:
> The ata_sas_port_alloc() wrapper mainly exists in order to export the
> internal libata function which it wraps. The secondary reason is that
> it initializes some ata_port struct members.
>
> However, ata_sas_port_alloc() is only used in a single location,
> sas_ata_init(), which already performs some ata_port struct member
> initialization, so it does not make sense to spread this initialization
> out over two separate locations.
>
> Thus, remove the wrapper and instead export the libata function directly,
> and move the libsas specific ata_port initialization to sas_ata_init(),
> which already does some ata_port initialization.
>
> Reviewed-by: Hannes Reinecke<hare@suse.de>
> Signed-off-by: Niklas Cassel<cassel@kernel.org>
Reviewed-by: John Garry <john.g.garry@oracle.com>
next prev parent reply other threads:[~2024-07-04 7:05 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-03 18:44 [PATCH v4 0/9] ata,libsas: Assign the unique id used for printing earlier Niklas Cassel
2024-07-03 18:44 ` [PATCH v4 1/9] ata,scsi: Remove wrappers ata_sas_tport_{add,delete}() Niklas Cassel
2024-07-03 18:44 ` [PATCH v4 2/9] ata: libata: Remove unused function declaration for ata_scsi_detect() Niklas Cassel
2024-07-03 18:44 ` [PATCH v4 3/9] ata: libata-core: Remove support for decreasing the number of ports Niklas Cassel
2024-07-03 18:44 ` [PATCH v4 4/9] ata: libata-sata: Remove superfluous assignment in ata_sas_port_alloc() Niklas Cassel
2024-07-03 18:44 ` [PATCH v4 5/9] ata: libata-core: Remove local_port_no struct member Niklas Cassel
2024-07-03 18:44 ` [PATCH v4 6/9] ata: libata: Assign print_id at port allocation time Niklas Cassel
2024-07-03 18:44 ` [PATCH v4 7/9] ata: libata-core: Reuse available ata_port print_ids Niklas Cassel
2024-07-03 18:44 ` [PATCH v4 8/9] ata,scsi: Remove wrapper ata_sas_port_alloc() Niklas Cassel
2024-07-04 7:04 ` John Garry [this message]
2024-07-03 18:44 ` [PATCH v4 9/9] ata: ahci: Add debug print for external port Niklas Cassel
2024-07-04 3:05 ` [PATCH v4 0/9] ata,libsas: Assign the unique id used for printing earlier Martin K. Petersen
2024-07-04 10:02 ` Niklas Cassel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3b22bcaf-064e-48a3-b81f-209d1d8ea518@oracle.com \
--to=john.g.garry@oracle.com \
--cc=James.Bottomley@HansenPartnership.com \
--cc=cassel@kernel.org \
--cc=dlemoal@kernel.org \
--cc=hare@suse.de \
--cc=linux-ide@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=yanaijie@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox