Re: [PATCH v4 17/28] null_blk: Introduce fua attribute

[Damien Le Moal <dlemoal@kernel.org>]

On 4/3/24 12:56, Chaitanya Kulkarni wrote:
> Damien,
> 
> On 4/2/24 05:38, Damien Le Moal wrote:
>>   +static bool g_fua = true;
>> +module_param_named(fua, g_fua, bool, S_IRUGO);
>> +MODULE_PARM_DESC(zoned, "Enable/disable FUA support when cache_size is used.
>> Default: true");
>> +
> 
> checkpatch is generating warning on this patch, please check :-
> 
> WARNING: Symbolic permissions 'S_IRUGO' are not preferred. Consider using octal
> permissions '0444'.
> #31: FILE: drivers/block/null_blk/main.c:229:
> +module_param_named(fua, g_fua, bool, S_IRUGO);
> 
> Also, I noticed that for zone_append_max_sectors attribute patch
> you are using 0444 but for fua you are using S_IRUGO, any specific
> reason ?

No particular reason. I probably followed the pattern around the code when I
added it.

Personnally, I find this checkpatch warning about S_IRUGO silly as it is far
more readable than 0444... Just my 2 cents. I can make the change if you insist.

> 
> -ck
> 
> 

-- 
Damien Le Moal
Western Digital Research