From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from 003.mia.mailroute.net (003.mia.mailroute.net [199.89.3.6]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 476847263D; Wed, 7 May 2025 19:28:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=199.89.3.6 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746646095; cv=none; b=N59KD5ajYIE2VLWeKHiNSq2UO3QvSXPkrSZVaTO+xx4OJ6i2jT9r7eAnT9IoOMcqwAxmMHe1qLY8Sabfoc/9sVPhD0iqwluGhvVIGXGwZkuUwqVnyXgqRNsRPv661eGlucusbZ/eJW/mYv8/ZdqIzMI8jF2pc7aTSQFjKpOhyDk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746646095; c=relaxed/simple; bh=ktcsDSMPQ+uFejH/2Mt2M7aBB0QDCgfvcowEvGROfmc=; h=Message-ID:Date:MIME-Version:Subject:To:References:From: In-Reply-To:Content-Type; b=gn8W2T8+gdE2Tahcsc91BfGO8w/E0Xb1Ajos9y65QuEseVMpVpYZtx6gIRkKuwI67YioOSDkUt/R5slFhqePSVNC3vCZLh77aPEF87l2F6CtBwL8QU4/ebQgpGrFncw7a29x/sgiCCsBhYCZjRjwUlFWK1knlk8ej3LpFmK19KA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=acm.org; spf=pass smtp.mailfrom=acm.org; dkim=pass (2048-bit key) header.d=acm.org header.i=@acm.org header.b=mrggc/i/; arc=none smtp.client-ip=199.89.3.6 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=acm.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=acm.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=acm.org header.i=@acm.org header.b="mrggc/i/" Received: from localhost (localhost [127.0.0.1]) by 003.mia.mailroute.net (Postfix) with ESMTP id 4Zt4zq5Z2DzlvRxg; Wed, 7 May 2025 19:28:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=acm.org; h= content-transfer-encoding:content-type:content-type:in-reply-to :from:from:content-language:references:subject:subject :user-agent:mime-version:date:date:message-id:received:received; s=mr01; t=1746646086; x=1749238087; bh=ktcsDSMPQ+uFejH/2Mt2M7aB B0QDCgfvcowEvGROfmc=; b=mrggc/i/H6MNLEMlYkKBIWpC2GxJ8wrhEROOsJVj C2u2AXrX03z5ndmrX3kkdhapy2ybwGqT+TfKCRHWauoIMvgFvonUPWB+ToXsIxLc h+vTsVhtRHF3yQ+zFG43uztoVH+SX//ca8Dn9CorRLHXgLAN9qvPjc8l24vGsRz7 yfJApjo6WwGIWjtuBthwP6p+ZcPDkj0Mk0XvwJT6IsRN1ko39R+ERH/t4W4i/srG OUqP1CLstusk+NuWJBXcGmbajDEdx6IbjMlT6qBhrwDJYBSH7Bbf9da9gimfD8LE /jhGNe6NXVNUWcQrlmF0NjBwvtjM5/ZkW40arnDh37RGoQ== X-Virus-Scanned: by MailRoute Received: from 003.mia.mailroute.net ([127.0.0.1]) by localhost (003.mia [127.0.0.1]) (mroute_mailscanner, port 10029) with LMTP id I0AqQzcsbx-3; Wed, 7 May 2025 19:28:06 +0000 (UTC) Received: from [100.66.154.22] (unknown [104.135.204.82]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: bvanassche@acm.org) by 003.mia.mailroute.net (Postfix) with ESMTPSA id 4Zt4zl1GrkzlvRxc; Wed, 7 May 2025 19:28:01 +0000 (UTC) Message-ID: <3b41510d-cd82-4c80-9651-ba9744f6ffc6@acm.org> Date: Wed, 7 May 2025 12:28:00 -0700 Precedence: bulk X-Mailing-List: linux-scsi@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] ufs: core: Print error value as hex format on ufshcd_err_handler() To: wkon-kim , James.Bottomley@HansenPartnership.com, martin.petersen@oracle.com, linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org References: <20250507020718.7446-1-wkon.kim@samsung.com> Content-Language: en-US From: Bart Van Assche In-Reply-To: <20250507020718.7446-1-wkon.kim@samsung.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 5/6/25 7:07 PM, wkon-kim wrote: > It is better to print saved_err and saved_uic_err in hex format. > Integer format is hard to spot. spot -> decode Anyway: Reviewed-by: Bart Van Assche