Re: [PATCH 08/26] block: Implement zone append emulation

Damien Le Moal
2024-02-05T23:57:14Z

On 2/6/24 02:58, Bart Van Assche wrote:
> On 2/1/24 23:30, Damien Le Moal wrote:
>> diff --git a/block/blk-zoned.c b/block/blk-zoned.c
>> index 661ef61ca3b1..929c28796c41 100644
>> --- a/block/blk-zoned.c
>> +++ b/block/blk-zoned.c
>> @@ -42,6 +42,8 @@ struct blk_zone_wplug {
>> unsigned int flags;
>> struct bio_list bio_list;
>> struct work_struct bio_work;
>> + unsigned int wp_offset;
>> + unsigned int capacity;
>> };
>
> This patch increases the size of struct blk_zone_wplug for all zoned storage
> use cases, including the use cases where zone append is not used at all.
> Shouldn't the size of this data structure depend on whether or not zone append
> is in use?

The block layer does not know what command the user/FS will be issuing.
And see patch 25 of the series for the memory optimization that mitigates the
increase of the struct size that this patch introduce.

--
Damien Le Moal
Western Digital Research