From: Damien Le Moal <dlemoal@kernel.org>
To: Christoph Hellwig <hch@lst.de>
Cc: Jens Axboe <axboe@kernel.dk>,
linux-block@vger.kernel.org, linux-scsi@vger.kernel.org,
"Martin K . Petersen" <martin.petersen@oracle.com>
Subject: Re: [PATCH v5 8/9] scsi: sd_zbc: always revalidate zones for disks supporting head depopulation
Date: Mon, 12 Oct 2026 16:57:58 +0200 [thread overview]
Message-ID: <3e8aad6d-c6b6-4299-9543-7ecff7758bfc@kernel.org> (raw)
In-Reply-To: <20261012143732.GD8609@lst.de>
On 2026/10/12 16:37, Christoph Hellwig wrote:
> Looks generally good:
>
> Reviewed-by: Christoph Hellwig <hch@lst.de>
>
> I think the Sashiko warning about the non-atomic bitfields is valid,
> but probably not sensible to address here. It would be great if
> someone could do a pass and convert the gazillions of scsi 1-bit
> bitfields to proper atomic bitops, though..
Yes, this is a recurring one. I need to send a patch to change all these 1-bit
flags into proper flags handled with test/set/clear_bit.
--
Damien Le Moal
Western Digital Research
next prev parent reply other threads:[~2026-10-12 14:58 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-12 13:01 [PATCH v5 0/9] Add support for storage element depopulation Damien Le Moal
2026-10-12 13:01 ` [PATCH v5 1/9] block: introduce disk_zone_is_offline() Damien Le Moal
2026-10-12 13:01 ` [PATCH v5 2/9] block: refactor blk_revalidate_disk_zones() Damien Le Moal
2026-10-12 13:01 ` [PATCH v5 3/9] block: introduce storage element management Damien Le Moal
2026-10-12 13:23 ` sashiko-bot
2026-10-12 13:27 ` Damien Le Moal
2026-10-12 14:23 ` Christoph Hellwig
2026-10-12 13:01 ` [PATCH v5 4/9] block: add storage element management ioctls Damien Le Moal
2026-10-12 13:40 ` sashiko-bot
2026-10-12 13:49 ` Damien Le Moal
2026-10-12 14:31 ` Christoph Hellwig
2026-10-12 14:56 ` Damien Le Moal
2026-10-12 14:57 ` Christoph Hellwig
2026-10-12 14:59 ` Damien Le Moal
2026-10-12 13:01 ` [PATCH v5 5/9] zloop: add storage element emulation Damien Le Moal
2026-10-12 13:52 ` sashiko-bot
2026-10-12 13:01 ` [PATCH v5 6/9] zloop: add degrade_element control command Damien Le Moal
2026-10-12 14:02 ` sashiko-bot
2026-10-12 14:43 ` Christoph Hellwig
2026-10-12 13:01 ` [PATCH v5 7/9] scsi: sd: fail read commands to offline zones early Damien Le Moal
2026-10-12 14:36 ` Christoph Hellwig
2026-10-12 13:01 ` [PATCH v5 8/9] scsi: sd_zbc: always revalidate zones for disks supporting head depopulation Damien Le Moal
2026-10-12 14:19 ` sashiko-bot
2026-10-12 14:37 ` Christoph Hellwig
2026-10-12 14:57 ` Damien Le Moal [this message]
2026-10-12 13:01 ` [PATCH v5 9/9] scsi: sd_zbc: define storage element management operations Damien Le Moal
2026-10-12 14:38 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3e8aad6d-c6b6-4299-9543-7ecff7758bfc@kernel.org \
--to=dlemoal@kernel.org \
--cc=axboe@kernel.dk \
--cc=hch@lst.de \
--cc=linux-block@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox