* BusLogic update - take 2
@ 2004-01-15 5:13 Bob Doyle
2004-01-21 13:47 ` Christoph Hellwig
0 siblings, 1 reply; 3+ messages in thread
From: Bob Doyle @ 2004-01-15 5:13 UTC (permalink / raw)
To: Christoph Hellwig; +Cc: linux-scsi
This is my second pass through the BusLogic SCSI driver. It
incorporates some comments received on the first version.
This patch is against linux-2.6.1. It works for me but the normal
caveats apply.
Please retrieve (~150kb) from:
<http://home.globalcrossing.net/~doyle/buslogic.patch>
Deleted dead code:
- BusLogic_ReportTargetDeviceInfo()
- BusLogic_SelectQueueDepths()
- BusLogic_SendBusDeviceReset()
- BusLogic_ResetCommand()
Fixed:
- removed dependency on "scsi_obsolete.h"
o Changes to BusLogic_ResetHostAdapter()
o Changes to BusLogic_AbortCommand()
- removed the gratuitous typedefs per Christoph's comments
- several functions with incorrect __init and __exit sections.
- Removed vestiges of the 'Error Recovery' command line function (which
is fundamentally incompatible with the new EH design).
Left to do:
- Test eh_abort_handler
- Test eh_host_reset_handler
- Test as module
- Straighten out FlashPoint conditional compile so it doesn't
require #include "FlashPoint.c".
- Please ignore the long line length and the very lengthy
identifiers (for now).
Bob.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: BusLogic update - take 2
2004-01-15 5:13 BusLogic update - take 2 Bob Doyle
@ 2004-01-21 13:47 ` Christoph Hellwig
2004-01-22 3:45 ` Bob Doyle
0 siblings, 1 reply; 3+ messages in thread
From: Christoph Hellwig @ 2004-01-21 13:47 UTC (permalink / raw)
To: Bob Doyle; +Cc: linux-scsi
What's this:?
+#ifndef FAILURE
+#define FAILURE (-1)
+#endif
else the patch looks okay to me
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: BusLogic update - take 2
2004-01-21 13:47 ` Christoph Hellwig
@ 2004-01-22 3:45 ` Bob Doyle
0 siblings, 0 replies; 3+ messages in thread
From: Bob Doyle @ 2004-01-22 3:45 UTC (permalink / raw)
To: Christoph Hellwig; +Cc: linux-scsi
Christoph Hellwig wrote:
> What's this:?
>
> +#ifndef FAILURE
> +#define FAILURE (-1)
> +#endif
>
> else the patch looks okay to me
The BusLogic.c code does a #include "FlashPoint.c" which conditionally defines
FAILURE when CONFIG_SCSI_OMIT_FLASHPOINT is not defined...
Eventually I'd like to get rid of that stupid include, compile the BusLogic
and FlashPoint drivers separately, and have the BusLogic module conditionally
load FlashPoint module - or something.
I'm not sure I have the stomach to touch the FlashPoint code.
Bob.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2004-01-22 3:45 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2004-01-15 5:13 BusLogic update - take 2 Bob Doyle
2004-01-21 13:47 ` Christoph Hellwig
2004-01-22 3:45 ` Bob Doyle
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).