Re: [PATCH] allow drivers to hook into watchdog timeout

[Brian King <brking@us.ibm.com>]

Christoph Hellwig wrote:
> We all know talk is cheap, so here's a first draft patch to allow LLDDs
> to get control first after a command timeout.  Justin, does this look
> okay for you?  BTW, your drivers are the last ones using scsi_add_timer
> from outside the midlayer, if we could get rid of that we'd be able to
> keep the interface private.

If we get rid of scsi_add_timer, could we have a scsi_mod_timer? In the 
ipr driver I submitted, I would like to be able to simply double the 
timeout value, I don't necessarily want to change the timeout policy. 
The adapter firmware is already timing each command, so I would like to 
use that as the primary timing mechanism if possible.

For normal SCSI devices under this adapter I could change the philosophy 
and not let the adapter time the commands, but for disk array devices, 
the timeout value for reads/writes is too short.


-- 
Brian King
eServer Storage I/O
IBM Linux Technology Center