public inbox for linux-scsi@vger.kernel.org
 help / color / mirror / Atom feed
From: Mike Christie <mikenc@us.ibm.com>
To: James Bottomley <James.Bottomley@SteelEye.com>
Cc: "Philip R. Auld" <pauld@egenera.com>,
	Simon Kelley <simon@thekelleys.org.uk>,
	SCSI Mailing List <linux-scsi@vger.kernel.org>,
	Jens Axboe <axboe@suse.de>
Subject: Re: Is there a grand plan for FC failover?
Date: Thu, 29 Jan 2004 15:25:11 -0800	[thread overview]
Message-ID: <40199657.2070106@us.ibm.com> (raw)
In-Reply-To: <1075392058.2381.44.camel@mulgrave>

James Bottomley wrote:
> On Thu, 2004-01-29 at 10:24, Philip R. Auld wrote:
> 
>>I think the place to do load balancing would be below the block queue so that
>>the IOs are coalesced. IMO, until you've merged the individual block requests 
>>you can't make a good decision about how to balance the load. 
> 
> 
> Yes, that's what I think too, so the elevator should go above dm, with a
> vestigial elevator between dm and sd simply for SCSI to use in queuing.


I do not think there is anyone that will disagree that there should be 
one elevator that does the sorting, merging, aging etc and that it 
should be at a different layer than it is today for DM multipath.

The modifications to DM to allow a multipath device to have a queue and 
to use it are minial. The problem is it's request_fn_proc. In the DM 
request_fn_proc we could just dequeue a request from the DM device's 
queue, clone it so the IO sched state does not get overwritten, map it 
to the correct lower level device queue, then insert it in the lower 
level device queue. Bad design right? We could do something similar 
where the request_fn_proc recieves a request instead of a queue like 
Jen's is planning for 2.7 
(http://www.kernel.org/pub/linux/kernel/people/axboe/experimental/), and 
then build a framework similar to bio remapping where we just clone and 
remap requests to the correct driver. But still a bad design right?

It doesn't seem like there are a lot of options for 2.6 with the current 
framework. We can add hints so we can try to make a decent decsion, but 
it isn't going to be perfect. But as James said the elevator problem is 
not a requirement for dm to actually work. I guess people will continue 
rolling their own solution if they feel the performance is that bad.

I cc'd Jens as he is best qualified to describe why there are problems 
with queueing requests between different queue's. I apoligize for 
bugging him about this again.


Mike


  reply	other threads:[~2004-01-29 23:25 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-01-26 14:18 Is there a grand plan for FC failover? Simon Kelley
2004-01-26 15:37 ` James Bottomley
2004-01-28 15:02   ` Philip R. Auld
2004-01-28 16:57     ` James Bottomley
2004-01-28 18:00       ` Philip R. Auld
2004-01-28 20:47         ` Patrick Mansfield
2004-01-28 22:14           ` James Bottomley
2004-01-29  0:55             ` Patrick Mansfield
2004-01-30 19:48               ` [dm-devel] " Joe Thornber
2004-01-31  9:30                 ` Jens Axboe
2004-01-31 16:59                   ` Philip R. Auld
2004-01-31 17:42                     ` Jens Axboe
2004-02-12 15:17                       ` Philip R. Auld
2004-02-12 15:28                         ` Arjan van de Ven
2004-02-12 16:03                           ` Philip R. Auld
2004-01-28 22:37         ` Mike Christie
2004-01-29 15:24           ` Philip R. Auld
2004-01-29 16:00             ` James Bottomley
2004-01-29 23:25               ` Mike Christie [this message]
  -- strict thread matches above, loose matches on Subject: below --
2004-01-28 21:02 Smart, James
2004-01-28 22:16 ` James Bottomley
2004-01-29 14:49   ` Philip R. Auld
2004-01-29 15:05     ` James Bottomley
2004-01-29 17:35 Smart, James
2004-01-29 18:31 ` Mike Anderson
2004-01-29 18:31 ` James Bottomley
2004-01-29 18:41 Smart, James
2004-01-29 19:37 Smart, James

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=40199657.2070106@us.ibm.com \
    --to=mikenc@us.ibm.com \
    --cc=James.Bottomley@SteelEye.com \
    --cc=axboe@suse.de \
    --cc=linux-scsi@vger.kernel.org \
    --cc=pauld@egenera.com \
    --cc=simon@thekelleys.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox